Date: Sat, 23 Sep 2017 19:33:26 -0400 From: Jonathan Looney <jonlooney@gmail.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: Stephen Hurd <shurd@sasktel.net>, Stephen Hurd <shurd@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323942 - head/sys/net Message-ID: <CADrOrmucv79mpd0Nk8vRmMUaFueQj0HUH8bJBvvyd42Qk=tN7A@mail.gmail.com> In-Reply-To: <6F5DC92C-2CF6-4A33-9663-BFECB7DB65F2@lists.zabbadoz.net> References: <201709230135.v8N1ZE6S063264@repo.freebsd.org> <B28D9879-4ECF-43E4-9A58-51F616CEC4BE@lists.zabbadoz.net> <283397c7-a01e-3776-7ed3-b64d68003d0b@sasktel.net> <6F5DC92C-2CF6-4A33-9663-BFECB7DB65F2@lists.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 23, 2017 at 4:37 AM, Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > > Then this makes no sense as we don=E2=80=99t do LRO if forwarding is enab= led on > the machine; > https://svnweb.freebsd.org/base/head/sys/netinet/tcp_lro.c? > annotate=3D317390#l645 Yes, that is true. However, this change still makes a difference. Previously, if LRO was not enabled or the packet was not eligible for LRO, the iflib code would call ifp->if_input() once for each packet. Now, the iflib code will build a chain of packets for which it couldn't do LRO and call ifp->if_input() once for the entire chain. (I agree that was not obvious from the rather short commit message and the diff in the email. The lack of comments or meaningful variable names did not help to alleviate the confusion. Nonetheless, when I looked at the diff with enough surrounding context, it became clear.) Jonathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADrOrmucv79mpd0Nk8vRmMUaFueQj0HUH8bJBvvyd42Qk=tN7A>