Date: Mon, 9 Jan 2012 07:57:29 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-arch@freebsd.org Cc: Adrian Chadd <adrian@freebsd.org>, Stefan Bethke <stb@lassitu.de> Subject: Re: Where should I put ar71xx_* modules? Message-ID: <201201090757.29250.jhb@freebsd.org> In-Reply-To: <CAJ-Vmo=peK%2BA%2BTnLVRZvf0TVSnCBisXRRpKgV%2BpwC-qL3-PABQ@mail.gmail.com> References: <CAJ-Vmom08uFV%2BNMryjZon_xnqo95MAK8r2=0s_JqRet7EMdn4g@mail.gmail.com> <DFFFE611-01A1-4B3F-8DFF-72E410483D5D@lassitu.de> <CAJ-Vmo=peK%2BA%2BTnLVRZvf0TVSnCBisXRRpKgV%2BpwC-qL3-PABQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, January 09, 2012 4:04:14 am Adrian Chadd wrote:
> On 9 January 2012 00:52, Stefan Bethke <stb@lassitu.de> wrote:
> > We have lots of modules that have specific requirements; they're still
connected to the build. What warrants different handling here? You could put
them under .if ${MACHINE_CPUARCH} != "mips" like a number of them are already.
>
> Hm, I didn't want to add modules for a specific SoC that won't ever be
> built for any other platform. Eg, if someone does a XLR build, they
> shouldn't get ar71xx modules built.
Were you planning on including them in the ar71xx kernel configs via
MODULES_OVERRIDE or some such? If so, that would be sufficient to get
'make tinderbox' to cover them at least (and hopefully tinderbox builds).
In that case I think it is fine to not have them hooked up in the main
sys/modules build. Or rather, if Warner commits his KERNOPTS thing, perhaps
you could make sys/modules/Makefile include them on appropriate SoC kernels
only.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201090757.29250.jhb>