Date: Fri, 21 Jun 2024 10:44:58 -0600 From: Warner Losh <imp@bsdimp.com> To: Ganael Laplanche <ganael.laplanche@martymac.org> Cc: freebsd-current@freebsd.org Subject: Re: pax(1) looping infinitely Message-ID: <CANCZdfody5vBjJXApkr1rbwq3X93J9BMQaOtWdzfJ=1Uf35NUg@mail.gmail.com> In-Reply-To: <da530e90-c380-47e9-b848-4c742959327f@martymac.org> References: <da530e90-c380-47e9-b848-4c742959327f@martymac.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000008bceea061b692764
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Fixed.
commit 681fd2bed8eaba88693867ba928a1c03a5b152cc (HEAD -> main)
Author: Ganael Laplanche <ganael.laplanche@martymac.org>
Date: Fri Jun 21 10:39:09 2024 -0600
pax: Terminate loop for empty directory names
...
Wrote the commit message and had to guess at the right email to use. But it
looked like bz and the mail here were the same.
In the future, simple patches like this might work better as a github pull
request, though, since that would resolve all that ambiguity.
Warner
On Fri, Jun 21, 2024 at 4:51=E2=80=AFAM Ganael Laplanche <
ganael.laplanche@martymac.org> wrote:
> Hello,
>
> Our pax(1) implementation has a small bug triggered when it is fed with
> a directory containing a trailing slash.
>
> Could a src committer have a look at:
>
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277060
>
> ?
>
> I've submitted a small patch that fixes the problem.
>
> Thanks!
>
> Cheers,
>
> --
> Ganael LAPLANCHE <ganael.laplanche@martymac.org>
> http://www.martymac.org | http://contribs.martymac.org
> FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org
>
>
--0000000000008bceea061b692764
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Fixed.<div><br></div><div>commit 681fd2bed8eaba88693867ba9=
28a1c03a5b152cc (HEAD -> main)<br>Author: Ganael Laplanche <<a href=
=3D"mailto:ganael.laplanche@martymac.org">ganael.laplanche@martymac.org</a>=
><br>Date: =C2=A0 Fri Jun 21 10:39:09 2024 -0600<br><br>=C2=A0 =C2=A0 pa=
x: Terminate loop for empty directory names<br></div><div>...</div><div><br=
></div><div>Wrote the commit message and had to guess at the right email to=
use. But it looked like bz and the mail here were the same.</div><div><br>=
</div><div>In the future, simple patches like this might work better as a g=
ithub pull request, though, since that would resolve all that ambiguity.</d=
iv><div><br></div><div>Warner</div><div><br></div></div><br><div class=3D"g=
mail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jun 21, 2024 at 4=
:51=E2=80=AFAM Ganael Laplanche <<a href=3D"mailto:ganael.laplanche@mart=
ymac.org">ganael.laplanche@martymac.org</a>> wrote:<br></div><blockquote=
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px so=
lid rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
Our pax(1) implementation has a small bug triggered when it is fed with <br=
>
a directory containing a trailing slash.<br>
<br>
Could a src committer have a look at:<br>
<br>
<a href=3D"https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277060" rel=
=3D"noreferrer" target=3D"_blank">https://bugs.freebsd.org/bugzilla/show_bu=
g.cgi?id=3D277060</a><br>
<br>
?<br>
<br>
I've submitted a small patch that fixes the problem.<br>
<br>
Thanks!<br>
<br>
Cheers,<br>
<br>
-- <br>
Ganael LAPLANCHE <<a href=3D"mailto:ganael.laplanche@martymac.org" targe=
t=3D"_blank">ganael.laplanche@martymac.org</a>><br>
<a href=3D"http://www.martymac.org" rel=3D"noreferrer" target=3D"_blank">ht=
tp://www.martymac.org</a> | <a href=3D"http://contribs.martymac.org" rel=3D=
"noreferrer" target=3D"_blank">http://contribs.martymac.org</a><br>;
FreeBSD: martymac <martymac@FreeBSD.org>, <a href=3D"http://www.FreeB=
SD.org" rel=3D"noreferrer" target=3D"_blank">http://www.FreeBSD.org</a><br>;
<br>
</blockquote></div>
--0000000000008bceea061b692764--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfody5vBjJXApkr1rbwq3X93J9BMQaOtWdzfJ=1Uf35NUg>