Date: Wed, 23 Sep 2015 10:01:21 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r287185 - head/share/mk Message-ID: <5602DAE1.8090600@FreeBSD.org> In-Reply-To: <CANCZdfpkogG9dN%2B56yo1c1Szn42oqCEft7ek8cabWezUeoUhNQ@mail.gmail.com> References: <201508270152.t7R1qks4074549@repo.freebsd.org> <56022B4C.7070407@FreeBSD.org> <CANCZdfpkogG9dN%2B56yo1c1Szn42oqCEft7ek8cabWezUeoUhNQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 9/23/2015 9:37 AM, Warner Losh wrote:
> I've been making a pass through the tree and found that
>
> FOO.${MK_BAR}+= a b c
>
> vs
>
> .if ${MK_BAR} != "no"
> FOO+= a b c
> .endif
>
Ah I see.
> simpler to understand. This commit is one small slice of that which I
> could commit. These files have a high enough churn rate that I'm not
> always able to keep up enough to push my changes. So this was part of
> what I could do today to start to reduce my patch-set.
>
> This was discussed on arch@freebsd.org <mailto:arch@freebsd.org> a while
> ago.
>
Sounds good, thanks.
--
Regards,
Bryan Drewery
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJWAtrhAAoJEDXXcbtuRpfPACcH/1aLo7B6OC2DSEyn67NgGQUe
VwF4iF+Pw+t6Ulcg+fCHVgrReO6nvN4112IYd1WDGF1H7X8PN7LnVVIE9M/5kluj
fkffhRqhIxKph8LSn+/zVfbi+xiypmjP7Df96VJ+m8ww0vABsIZ1JuiSLhFjwd8F
92GBMoJUrNOaXjFDLmGYxF6nb7KVaos907NWvKeksIeT/3qCYRT4eVXg0761fvSb
D8qemIUPleX6Be2iyW5GlEYZfej6ShkZVPysFeSxvFaoMr7wHlS6sM1t3whHzch0
daumqtEv3aoz/e4IsPxnyIc9uihbFqLwB/K76eh3bZIPmzWl+2gmOHlLtD2lYC4=
=30G1
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5602DAE1.8090600>