Date: Tue, 5 Apr 2005 13:04:35 +0000 (UTC) From: Poul-Henning Kamp <phk@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/lib/libalias alias.c Message-ID: <200504051304.j35D4ZiX042502@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
phk 2005-04-05 13:04:35 UTC
FreeBSD src repository
Modified files:
lib/libalias alias.c
Log:
natd core dumps when -reverse switch is used because of a bug in
libalias.
In /usr/src/lib/libalias/alias.c, the functions LibAliasIn and
LibAliasOutTry call the legacy PacketAliasIn/PacketAliasOut instead
of LibAliasIn/LibAliasOut when the PKT_ALIAS_REVERSE option is set.
In this case, the context variable "la" gets lost because the legacy
compatibility routines expect "la" to be global. This was obviously
an oversight when rewriting the PacketAlias* functions to the
LibAlias* functions.
The fix (as shown in the patch below) is to remove the legacy
subroutine calls and replace with the new ones using the "la" struct
as the first arg.
Submitted by: Gil Kloepfer <fgil@kloepfer.org>
Confirmed by: <nicolai@catpipe.net>
PR: 76839
MFC after: 3 days
Revision Changes Path
1.50 +2 -2 src/lib/libalias/alias.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200504051304.j35D4ZiX042502>