Date: Wed, 5 Apr 2017 22:01:49 +0000 (UTC) From: Sean Bruno <sbruno@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r316544 - head/sys/dev/ixgbe Message-ID: <201704052201.v35M1nU9094324@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: sbruno Date: Wed Apr 5 22:01:49 2017 New Revision: 316544 URL: https://svnweb.freebsd.org/changeset/base/316544 Log: Don't overrite vf->flags variable at the end of ixgbe(4) ixgbe_add_vf(). Found by PVS-Studio Static code analyzer. PR: 217748 Submitted by: razmyslov@viva64.com MFC after: 1 week Modified: head/sys/dev/ixgbe/if_ix.c Modified: head/sys/dev/ixgbe/if_ix.c ============================================================================== --- head/sys/dev/ixgbe/if_ix.c Wed Apr 5 21:08:26 2017 (r316543) +++ head/sys/dev/ixgbe/if_ix.c Wed Apr 5 22:01:49 2017 (r316544) @@ -5991,7 +5991,7 @@ ixgbe_add_vf(device_t dev, u16 vfnum, co */ vf->flags |= IXGBE_VF_CAP_MAC; - vf->flags = IXGBE_VF_ACTIVE; + vf->flags |= IXGBE_VF_ACTIVE; ixgbe_init_vf(adapter, vf); IXGBE_CORE_UNLOCK(adapter);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704052201.v35M1nU9094324>