Date: Sun, 1 Sep 2019 11:07:01 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: "Conrad E. Meyer" <cem@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r351643 - in head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common: dtraceUtil speculation Message-ID: <FFB0A7EC-43FF-4012-9344-0F3A191BB4FA@gmail.com> In-Reply-To: <CANCZdfrbwO%2BW7zVH6%2B=Jr09jONyqMnoT7ejavCh%2BNopBvcuyHg@mail.gmail.com> References: <201908311441.x7VEfwZ3045957@repo.freebsd.org> <CAG6CVpVf%2BY5uABKsJhS2LubT6BnmWmeMWF7M0HN1n4eQdZW6fg@mail.gmail.com> <CANCZdfrbwO%2BW7zVH6%2B=Jr09jONyqMnoT7ejavCh%2BNopBvcuyHg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Aug 31, 2019, at 16:29, Warner Losh <imp@bsdimp.com> wrote: >=20 >=20 >=20 >> On Sat, Aug 31, 2019 at 5:29 PM Conrad Meyer <cem@freebsd.org> wrote: >> Thanks Li-Wen! Might it be less fragile to have the test fixture >> create a file, if the test(s) will expect one to be present to read? >=20 > Or just use the realpath $0, which you know has to exist :) I don=E2=80=99t know if this would work, with other some of the dtrace tests= are called. Plus, that relies on a FreeBSD utility which doesn=E2=80=99t ne= cessarily exist on Linux and I don=E2=80=99t think exists on IllumOS. It makes more sense to create a file with mktemp and test for it in the loop= to make the tests portable over to IllumOS, since that=E2=80=99s where they= originally came from and can be contributed back to. Thanks, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FFB0A7EC-43FF-4012-9344-0F3A191BB4FA>