Date: Mon, 23 Aug 2004 21:39:29 +0000 (UTC) From: Peter Wemm <peter@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/amd64/amd64 mp_machdep.c pmap.c src/sys/i386/i386 mp_machdep.c pmap.c src/sys/kern subr_smp.c src/sys/sys smp.h Message-ID: <200408232139.i7NLdToC094668@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
peter 2004-08-23 21:39:29 UTC
FreeBSD src repository
Modified files:
sys/amd64/amd64 mp_machdep.c pmap.c
sys/i386/i386 mp_machdep.c pmap.c
sys/kern subr_smp.c
sys/sys smp.h
Log:
Commit Doug White and Alan Cox's fix for the cross-ipi smp deadlock.
We were obtaining different spin mutexes (which disable interrupts after
aquisition) and spin waiting for delivery. For example, KSE processes
do LDT operations which use smp_rendezvous, while other parts of the
system are doing things like tlb shootdowns with a different mutex.
This patch uses the common smp_rendezvous mutex for all MD home-grown
IPIs that spinwait for delivery. Having the single mutex means that
the spinloop to aquire it will enable interrupts periodically, thus
avoiding the cross-ipi deadlock.
Obtained from: dwhite, alc
Reviewed by: jhb
Revision Changes Path
1.243 +2 -5 src/sys/amd64/amd64/mp_machdep.c
1.492 +6 -6 src/sys/amd64/amd64/pmap.c
1.236 +2 -4 src/sys/i386/i386/mp_machdep.c
1.495 +8 -8 src/sys/i386/i386/pmap.c
1.189 +8 -1 src/sys/kern/subr_smp.c
1.78 +1 -0 src/sys/sys/smp.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200408232139.i7NLdToC094668>