Date: Wed, 03 Nov 2004 09:49:45 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: scottl@FreeBSD.ORG Cc: cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/em if_em.c Message-ID: <20041103.094945.22504907.imp@bsdimp.com> In-Reply-To: <41890956.2030705@freebsd.org> References: <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> <41890956.2030705@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <41890956.2030705@freebsd.org>
Scott Long <scottl@FreeBSD.org> writes:
: Luigi Rizzo wrote:
: > On Wed, Nov 03, 2004 at 09:23:01AM -0700, Scott Long wrote:
: > ...
: >
: >>I think that in general we can start eyeing a lot of similar verbosity
: >>in all of our drivers, both at boot and at runtime. For example most
: >>nic drivers print out their MAC and all of their possible negotiation
: >>rates on attach. This same info can be obtained from ifconfig. Why
: >>clutter the boot with it?
: >
: >
: > because sometimes you might need to enable some MAC-based filter
: > before you have a chance to access the box. e.g. to set dhcp/bootp
: > anbd the like.
: >
: > A bit of verbosity is useful, you can always switch to splash screens
: > if you don't like them.
: >
: > I think the link-up/link-down thing is different because it
: > happens not just at boot but also whenever the link status
: > changes (e.g. when a spanning tree on a switch detects a
: > reconfiguration), and this is annoying on the console.
: >
: > cheers
: > luigi
: >
:
: I'm not saying that these things should be removed, just places under
: bootverbose. Situations like what you are saying are rare and/or
: one-time occurances. And if you look at drivers like if_ath(no offense
: meant towards Sam):
:
: ath0: <Atheros 5212> mem 0xf4010000-0xf401ffff irq 11 at device 0.0 on
: cardbus1
: ath0: mac 5.6 phy 4.1 5ghz radio 1.7 2ghz radio 2.3
: ath0: Ethernet address: 00:0c:41:15:5f:94
: ath0: 11a rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps
: ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps
: ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps
: 24Mbps 36Mbps 48Mbps 54Mbps
: ath0: turbo rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps
:
: The last 4 lines could easily go under bootverbose. I'd even wager that
: the second line can be hidden also; it provides little useful
: information for a normal boot.
Agreed. The second line should likely be exported as a series of
sysctls under dev.ath.0.mac_version, dev.ath.0.phy_version, etc if
they are important.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041103.094945.22504907.imp>