Date: Mon, 16 Aug 2004 09:55:23 -0400 From: John Baldwin <jhb@FreeBSD.org> To: "David E. O'Brien" <obrien@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile Message-ID: <200408160955.23819.jhb@FreeBSD.org> In-Reply-To: <200408160937.43004.jhb@FreeBSD.org> References: <200408160828.i7G8SwGn067849@repoman.freebsd.org> <200408160937.43004.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 16 August 2004 09:37 am, John Baldwin wrote: > On Monday 16 August 2004 04:28 am, David E. O'Brien wrote: > > obrien 2004-08-16 08:28:58 UTC > > > > FreeBSD src repository > > > > Modified files: > > release Makefile > > Log: > > Accept the fact that floppies either aren't applicable or relevant on > > most platforms. So make the floppy logic easier to read. > > Please revert this unreviewed commit. I like to build releases at work > with 'NO_FLOPPIES=yes' on i386 just so I can skip the extra time spent > building floppies when I only do installs over FTP and CD-ROM. Changing > the sense of the knob breaks that feature. This also has basically zero > impact as far as readability. Well, I see you did fix this eventually but it sure would be nice if you would get gratuitous code churn reviewed first. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200408160955.23819.jhb>