Date: Wed, 7 Aug 2013 04:26:03 GMT From: Sean Bruno <sbruno@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/181101: [patch] audio/clementine needs patch for deprecated g_type_init() Message-ID: <201308070426.r774Q3im060295@oldred.freebsd.org> Resent-Message-ID: <201308070430.r774U0br058210@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 181101 >Category: ports >Synopsis: [patch] audio/clementine needs patch for deprecated g_type_init() >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Aug 07 04:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Sean Bruno >Release: -CURRENT >Organization: FreeBSD Project >Environment: FreeBSD alice 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r254018: Tue Aug 6 19:17:07 PDT 2013 sbruno@alice:/usr/obj/usr/src/sys/ALICE amd64 >Description: GLIB bumped its version so that after 2.36.0 g_type_init() needs to be ignored. ref: http://code.google.com/p/clementine-player/source/detail?r=2cdbe9ea8247 Without this patch, the port emits the following build error: main.cpp:268:3: error: ‘void g_type_init()’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Werror=deprecated-declarations] g_type_init(); >How-To-Repeat: build audio/clemetine-player >Fix: Apply patch: Patch attached with submission follows: --- src/main.cpp 2012-11-18 00:51:27.000000000 -0800 +++ ../../work.fixed/clementine-1.1.1/src/main.cpp 2013-08-06 20:55:06.046505976 -0700 @@ -265,7 +265,9 @@ #endif // This makes us show up nicely in gnome-volume-control - g_type_init(); +#if !GLIB_CHECK_VERSION(2, 36, 0) + g_type_init(); // Deprecated in glib 2.36.0 +#endif g_set_application_name(QCoreApplication::applicationName().toLocal8Bit()); RegisterMetaTypes(); >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201308070426.r774Q3im060295>