Date: Fri, 10 May 2013 08:43:37 -0400 From: Eitan Adler <eadler@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r250430 - head/sbin/dmesg Message-ID: <CAF6rxgkHDzMPY7za8z--SSPz3VJGisM_nT96CX9xxKvU4h5TxA@mail.gmail.com> In-Reply-To: <20130510074235.GA19945@FreeBSD.org> References: <201305100342.r4A3gmc9080595@svn.freebsd.org> <20130510074235.GA19945@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 May 2013 03:42, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, May 10, 2013 at 03:42:48AM +0000, Eitan Adler wrote: >> New Revision: 250430 >> URL: http://svnweb.freebsd.org/changeset/base/250430 >> >> @@ -79,15 +80,20 @@ main(int argc, char *argv[]) >> kvm_t *kd; >> size_t buflen, bufpos; >> long pri; >> - int all, ch; >> + int ch, clear; >> + bool all; >> >> - all = 0; >> + all = false; >> + clear = false; >> (void) setlocale(LC_CTYPE, ""); > > It's a bit weird that you've left the cast here... I didn't modify this line > > ... and here (also: notice inconsistent spacing), Or this one. >> void >> usage(void) >> { >> - (void)fprintf(stderr, "usage: dmesg [-a] [-M core [-N system]]\n"); >> + fprintf(stderr, "usage: dmesg [-ac] [-M core [-N system]]\n"); > > but removed it here for no particular reason. Notice the additional 'c' in usage(). -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkHDzMPY7za8z--SSPz3VJGisM_nT96CX9xxKvU4h5TxA>