Date: Tue, 17 Feb 2015 12:32:57 -0800 From: John-Mark Gurney <jmg@funkthat.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r278831 - head/sys/netpfil/pf Message-ID: <20150217203257.GH1953@funkthat.com> In-Reply-To: <20150217202154.GS15484@FreeBSD.org> References: <201502160338.t1G3cRlX042385@svn.freebsd.org> <20150217173134.GZ1953@funkthat.com> <20150217202154.GS15484@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb Smirnoff wrote this message on Tue, Feb 17, 2015 at 23:21 +0300: > On Tue, Feb 17, 2015 at 09:31:34AM -0800, John-Mark Gurney wrote: > J> Gleb Smirnoff wrote this message on Mon, Feb 16, 2015 at 03:38 +0000: > J> > Author: glebius > J> > Date: Mon Feb 16 03:38:27 2015 > J> > New Revision: 278831 > J> > URL: https://svnweb.freebsd.org/changeset/base/278831 > J> > > J> > Log: > J> > Update the pf fragment handling code to closer match recent OpenBSD. > J> > That partially fixes IPv6 fragment handling. Thanks to Kristof for > J> > working on that. > J> > > J> > Submitted by: Kristof Provost > J> > Tested by: peter > J> > Differential Revision: D1765 > J> > J> Looks like pf_flush_fragments still called in !INET case, though only > J> defined for INET case: > J> /scratch/tmp/jmg/src.head/sys/modules/pf/../../netpfil/pf/pf_norm.c:385:3: error: implicit declaration of function 'pf_flush_fragments' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > J> pf_flush_fragments(); > J> > J> when compiling LINT-NOINET kernel.. > J> > J> at least as of r278883... > J> > J> We need to get Jenkins to be compiling the LINT-NOINET kernel too.. > > Strange, since r278874 was tested with KERNCONF="LINT LINT-NOINET LINT-NOINET6". > > I will take a look. This is a result of a tinderbox build on ref10-amd64.freebsd.org... Look at /scratch/tmp/jmg/src.head/*NOINET -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150217203257.GH1953>