Date: Tue, 22 Aug 2023 10:48:19 -0600 From: Warner Losh <imp@bsdimp.com> To: Enji Cooper <yaneurabeya@gmail.com> Cc: John Baldwin <jhb@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 7a56f5af7185 - main - libcrypto: Don't embed $FreeBSD$ in generated assembly files Message-ID: <CANCZdfoQhHk-TFGaDtgLw1u1Sac7gXkLeq4a9_%2BR_dFqN0RDGg@mail.gmail.com> In-Reply-To: <A1051FDF-7E85-41A9-A629-AADCAFF9564C@gmail.com> References: <202308220404.37M44LWJ093340@gitrepo.freebsd.org> <A1051FDF-7E85-41A9-A629-AADCAFF9564C@gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Aug 22, 2023 at 10:21 AM Enji Cooper <yaneurabeya@gmail.com> wrote: > > > On Aug 21, 2023, at 9:04 PM, John Baldwin <jhb@freebsd.org> wrote: > > > > The branch main has been updated by jhb: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=7a56f5af71851c8b502720ca956629c302821430 > > > > commit 7a56f5af71851c8b502720ca956629c302821430 > > Author: John Baldwin <jhb@FreeBSD.org> > > AuthorDate: 2023-08-22 04:01:48 +0000 > > Commit: John Baldwin <jhb@FreeBSD.org> > > CommitDate: 2023-08-22 04:01:48 +0000 > > > > libcrypto: Don't embed $FreeBSD$ in generated assembly files > > > > Reviewed by: gallatin, ngie, emaste > > Differential Revision: https://reviews.freebsd.org/D41536 > > I wonder — should this be MFCed? It doesn’t seem like there’s much value > in the $FreeBSD$ tags now that FreeBSD has moved its source to git. > I literally have the MFC of all this junk to stable/13 sitting on my machine waiting for it to make it through universe. Note: I think we need to fix the first few lines of this Makefile though: # to the arch subdir, and correct any exposed paths and $ FreeBSD $ tags. to s/,.*\././ since that last bit is no longer relevant. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 22, 2023 at 10:21 AM Enji Cooper <<a href="mailto:yaneurabeya@gmail.com">yaneurabeya@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> > On Aug 21, 2023, at 9:04 PM, John Baldwin <<a href="mailto:jhb@freebsd.org" target="_blank">jhb@freebsd.org</a>> wrote:<br> > <br> > The branch main has been updated by jhb:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=7a56f5af71851c8b502720ca956629c302821430" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=7a56f5af71851c8b502720ca956629c302821430</a><br>; > <br> > commit 7a56f5af71851c8b502720ca956629c302821430<br> > Author: John Baldwin <jhb@FreeBSD.org><br> > AuthorDate: 2023-08-22 04:01:48 +0000<br> > Commit: John Baldwin <jhb@FreeBSD.org><br> > CommitDate: 2023-08-22 04:01:48 +0000<br> > <br> > libcrypto: Don't embed $FreeBSD$ in generated assembly files<br> > <br> > Reviewed by: gallatin, ngie, emaste<br> > Differential Revision: <a href="https://reviews.freebsd.org/D41536" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D41536</a><br>; <br> I wonder — should this be MFCed? It doesn’t seem like there’s much value in the $FreeBSD$ tags now that FreeBSD has moved its source to git.<br></blockquote><div><br></div><div>I literally have the MFC of all this junk to stable/13 sitting on my machine waiting for it to make it through universe.</div><div><br></div><div>Note: I think we need to fix the first few lines of this Makefile though:</div><div><br></div><div># to the arch subdir, and correct any exposed paths and $ FreeBSD $ tags.<br></div><div><br></div><div>to s/,.*\././ since that last bit is no longer relevant.</div><div><br></div><div>Warner</div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoQhHk-TFGaDtgLw1u1Sac7gXkLeq4a9_%2BR_dFqN0RDGg>