Date: Thu, 04 Dec 2025 19:00:06 +0100 From: Olivier Certner <olce@freebsd.org> To: java@freebsd.org, Ronald Klop <ronald-lists@klop.ws> Cc: ports@freebsd.org Subject: Re: make it possible to compile bouncycastle with jdk21 Message-ID: <3084524.slGk94SIus@ravel> In-Reply-To: <991224173.9384.1764865323241@localhost> References: <991224173.9384.1764865323241@localhost>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
Hi,
I have the same changes as yours plus an old patch that I did a while ago to enable building with openjdk11. I guess it is not needed for jdk21, but it shouldn't hurt:
diff --git a/java/bouncycastle/files/patch-ant_bc+-build.xml b/java/bouncycastle/files/patch-ant_bc+-build.xml
new file mode 100644
index 000000000000..d8c18203edf1
--- /dev/null
+++ b/java/bouncycastle/files/patch-ant_bc+-build.xml
@@ -0,0 +1,26 @@
+--- ant/bc+-build.xml.orig 2022-01-31 06:50:53 UTC
++++ ant/bc+-build.xml
+@@ -118,6 +118,7 @@
+ <mkdir dir="${artifacts.dir}/@{target}" />
+
+ <javac source="${bc.javac.source}" target="${bc.javac.target}"
++ encoding="UTF-8"
+ srcdir="${artifacts.dir}/@{target}/src"
+ destdir="${build.dir}/@{target}/classes"
+ memoryMaximumSize="512m"
+@@ -155,6 +156,7 @@
+ <mkdir dir="${artifacts.dir}/@{target}" />
+
+ <javac source="${bc.javac.source}" target="${bc.javac.target}"
++ encoding="UTF-8"
+ srcdir="${artifacts.dir}/@{target}/src"
+ destdir="${build.dir}/@{target}/classes"
+ memoryMaximumSize="512m"
+@@ -302,6 +304,7 @@
+ </copy>
+
+ <javac source="${bc.javac.source}" target="${bc.javac.target}"
++ encoding="UTF-8"
+ srcdir="${lcrypto.target.src.dir}"
+ destdir="${lcrypto.target.classes.dir}"
+ memoryMaximumSize="512m"
Without it, I get errors like:
/wrkdirs/usr/ports/java/bouncycastle/work/crypto-171/build/artifacts/jdk1.8/bcprov-jdk18on-171/src/org/bouncycastle/crypto/generators/Argon2BytesGenerator.java:489: error: unmappable character (0xCF) for encoding US-ASCII
* H0 = H64(p, ??, m, t, v, y, |P|, P, |S|, S, |L|, K, |X|, X)
Could you test building with this patch? I'm not versed in Java building, so maybe there is some better way than that. Perhaps it's openjdk11 itself that should be compiled differently to default to UTF-8?
Thanks and regards.
--
Olivier Certner
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmkxzCYACgkQjKEwQJce
JieVNA//XJXxTzy5xCSxft4/LozZsDGGjxYjQKs6cGJI4WAWjT/zYQ/qhKHR8G6u
d6MCX2yQ6cyNY5RF1Le3ruxyiLAEtdtSA6NeyCuRDxezmbeckK+drnNgiyXEPYbW
RUCq/qHS3aq7ZPDbLNwUWOASU+eHDHVqiI5/s5Es4l7nIqrtPcobBzv7gJY83zh1
REH19HLatUb1l/sHu5rUTv5q7sIlf+UUlvkYKWXNj+l0dnH+XbLJbOsnU72Y6EHD
55jnSXXzkUD308IYwK/CAGT0URmOUvi0NdzEaZ4MXjjXq2j/+y74Kssah20fGTZ7
MFLA8+zAfoU7pfGz1SYKvM6geV5kuOlAjufK4ZqKa6BNYPwSYZs1Mvau+q0IkFQa
88ecu4E+ivHmXXpLKsJ6DHTDaQIBwFl2O7iwtnikLAjmid6Tar0mZEUaUn8zHlAP
Rg+QgxjJE3BKsVrWPBjuzg5lXx+LLUiu3QO1XdA/A/zi725/OMdiLyxTNBv04Ncg
hSQWvTtCbjIugZ/+JxH55Ub0mPTCAYodaYkkgPgAxWO00+xRQBzFDp+fOc8OghQF
mxQh70opn3bH1NCK0hSfK9c49zmYG3my9zPBwa/dFPQnR+hXUUOOSo1TG1UDr7WQ
MvT2V6Q7yTf4yhTvXmPUZWgUJwaMWSBKkmvBDtSzdFP6p9E/Eh0=
=1dV9
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3084524.slGk94SIus>