Date: Sun, 3 Mar 2024 11:30:46 +0100
From: Mathieu Arnold <mat@freebsd.org>
To: Gleb Popov <arrowd@freebsd.org>
Cc: Thomas Zander <riggs@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject: Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG
Message-ID: <5rhletz56xtstyf24ly4pq63grgs3sfgzjlg7ojpdhw66mjsge@xh7bxfu44ifq>
In-Reply-To: <CALH631mJShhLMkULtyBSyc1H%2BH4fZBfrt=adxTGe1WxVYcPXQw@mail.gmail.com>
References: <202403021836.422Ia4o2021754@gitrepo.freebsd.org> <CALH631k%2BK%2Bf2Tpmk9HGX%2BWydcB8xe-xquRSKYitUzXGc7eO4bQ@mail.gmail.com> <5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay@qbtuvdsmy7fk> <CALH631mJShhLMkULtyBSyc1H%2BH4fZBfrt=adxTGe1WxVYcPXQw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Mar 03, 2024 at 12:01:41PM +0300, Gleb Popov wrote: > On Sun, Mar 3, 2024 at 11:56 AM Mathieu Arnold <mat@freebsd.org> wrote: > > > > There is no trend, it's a rule, debug must be handled with WITH_DEBUG > > knob, and not via an option. > > If there is an option that enable some sort of debugging or verbose > > thing but that is not supposed to add debugging symbols, then it should > > not be called DEBUG. > > In that case we need a qa check that prevents adding DEBUG option and > then we can also introduce a generic DEBUG_VAR helper to get rid of > ifdefs? Oh, sorry, I made a mess of things, and I woke up completely, my brain short circuited for a while. A DEBUG option is fine, as long as it MUST NOT enable WITH_DEBUG. WITH_DEBUG is a user facing variable, that MUST NOT be set in a port. -- Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXkUVZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb7MUAwAzOnBcS2vo8cuPvRVF0cWilN/iQuWH+SOqX5KooRjo5VNiiK2ykRsU+3U wp0OJNmFvz6apDMKabXL4gHPL4kIgeiszAWnQVOvdTpDwsIIggBe2bFsfkOks7Kw OYQgRcFZlBlGVfUJlLzWG/5VqjENu+amhymslfxKjz51xBFbWj8Ebp5tzGdmzHxE wqnnB/10vOEL2U9gAumYEO5UFP7tvubcYsrNpBGsJ6jhp7hOF6F9X8/2WOZvDgS/ 2nvUrq75AtFKov+2yu4GRZ7Ymz31bJ+FB9O0y2lMuLY9SkBCCT/gXlgTn1WxY5vW e5XfuYpVgQv5j+LdFHi8zarQ6/bnjoS8qSVbVX8DyesGEmkSrhe2KV2fUuNuWf9a LBnLRoVzsIppnuT39ntPuNm0WMAljsCqe/PkGtxWbBWZcdzGMZZU8GVAjk+Juklw suvWKS78cI07dC8xsfI27PYlmir8wgHml2ox57jRcSri/jjCkVR+fO1iOZWKSigC KcQLZlMP =dREH -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5rhletz56xtstyf24ly4pq63grgs3sfgzjlg7ojpdhw66mjsge>