Date: Thu, 28 Dec 1995 14:18:15 -0800 From: Paul Traina <pst@shockwave.com> To: "Garrett A. Wollman" <wollman@lcs.mit.edu> Cc: Joerg Wunsch <joerg@freefall.freebsd.org>, CVS-committers@freefall.freebsd.org, cvs-lib@freefall.freebsd.org Subject: Re: cvs commit: src/lib/libc/gen getpass.c Message-ID: <199512282218.OAA12618@precipice.shockwave.com> In-Reply-To: Your message of "Thu, 28 Dec 1995 13:06:19 EST." <9512281806.AA23043@halloran-eldar.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Two points:
(a) you two just changed the semantics of this routine, you need to check
all of the callers to make sure THEY block SIGINT and SIGTSTP.
(b) This is a bad idea if you use ^C or ^Z as part of your password, which
was legal.
Paul
From: "Garrett A. Wollman" <wollman@lcs.mit.edu>
Subject: cvs commit: src/lib/libc/gen getpass.c
<<On Wed, 27 Dec 1995 15:23:01 -0800 (PST), Joerg Wunsch <joerg@freefall.free
>>bsd.org> said:
> joerg 95/12/27 15:23:01
> Modified: lib/libc/gen getpass.c
> Log:
> Don't block SIGINT in getpass(3); this doesn't make sense.
It shouldn't block SIGTSTP, either. (The calling program should if
it's important.) This is very obnoxious when I'm on a text console
attempting to FTP somewhere using S/Key, since it is impossible to
suspend ftp while it's prompting for a password. Under OSF/1, it
works.
-GAWollman
--
Garrett A. Wollman | Shashish is simple, it's discreet, it's brief. ...
wollman@lcs.mit.edu | Shashish is the bonding of hearts in spite of distance
>>.
Opinions not those of| It is a bond more powerful than absence. We like peop
>>le
MIT, LCS, ANA, or NSA| who like Shashish. - Claude McKenzie + Florent Vollan
>>t
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199512282218.OAA12618>