Date: Thu, 24 Jun 2010 14:39:39 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: nwhitehorn@freebsd.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209511 - head Message-ID: <20100624.143939.85384790471796385.imp@bsdimp.com> In-Reply-To: <20100624151959.6b00bfdd@anacreon.physics.wisc.edu> References: <201006241753.o5OHrPnU058288@svn.freebsd.org> <20100624151959.6b00bfdd@anacreon.physics.wisc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20100624151959.6b00bfdd@anacreon.physics.wisc.edu> Nathan Whitehorn <nwhitehorn@freebsd.org> writes: : On Thu, 24 Jun 2010 17:53:25 +0000 (UTC) : Warner Losh <imp@FreeBSD.org> wrote: : : > Author: imp : > Date: Thu Jun 24 17:53:25 2010 : > New Revision: 209511 : > URL: http://svn.freebsd.org/changeset/base/209511 : > : > Log: : > Merge from tbemd: : > : > use MACHINE_CPUARCH instead of MACHINE_CPU since the sources for the : > CSU is based on MACHINE_CPUARCH : > : > Reviewed by: arch@ (twice) : : This is not always true. For example, on powerpc64, the ABI is : different enough between powerpc and powerpc64, which share a CPUARCH, : that the csu code shares very little. I can work around this with : Makefile or preprocessor hacks, of course, but would be it be possible : here instead to check for MACHINE_ARCH before falling back to : MACHINE_CPUARCH? I can do the nested search. It won't break mips or arm, since the mipsel or mipseb variant won't exist... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100624.143939.85384790471796385.imp>