Date: Fri, 01 May 2009 11:32:03 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191717 - head/sys/dev/ata Message-ID: <49FAB383.2010904@FreeBSD.org> In-Reply-To: <48416.1241165732@critter.freebsd.dk> References: <48416.1241165732@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp wrote: > In message <200905010803.n4183kGE036016@svn.freebsd.org>, Alexander Motin write > s: > >> - Drop pre-dump requests queue on dumping. ATA code, working in dumping >> (interruptless) mode, unable to handle long request queue. Actually, to get >> coherent dump we anyway should do as few unrelated actions as possible. > > It seems a wrong tradeoff to me, to favour dump fidelity over filesystem > coherence. When dump is disabled, queued requests are trashed anyway. Dump does not make the things worse then they are. It just does it's duty as good as possible and as simple as possible. There is no any warranty that completing all queued requests will make filesystem more coherent, it easily can happen opposite. Also, as soon as current system state is known to be invalid (as kernel has just panicked), it could be safer do not try to make any excessive movements. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49FAB383.2010904>