Date: Sat, 1 May 2010 17:12:52 +0900 From: Taku YAMAMOTO <taku@tackymt.homeip.net> To: Jack Vogel <jfvogel@gmail.com> Cc: freebsd-current@freebsd.org Subject: if_em.c prevents the 2nd time resuming Message-ID: <20100501171252.e05f257f.taku@tackymt.homeip.net>
next in thread | raw e-mail | index | archive | help
Greetings,
I found a bug in if_em.c which triggers a panic when resuming from the 2nd
suspend. (sleep, wakeup, sleep and wakeup will result to a panic)
It seems it has got introduced by r206001 (head) or r206211 (stable/8).
I guess the following change mistakenly slipped into em_resume() which is
completely bogus (suppose these lines should go into em_detach()?):
@@ -769,6 +774,9 @@
struct adapter *adapter = device_get_softc(dev);
struct ifnet *ifp = adapter->ifp;
+ if (adapter->led_dev != NULL)
+ led_destroy(adapter->led_dev);
+
EM_CORE_LOCK(adapter);
em_init_locked(adapter);
em_init_manageability(adapter);
Should I file a PR?
Virtually yours,
--
-|-__ YAMAMOTO, Taku
| __ < <taku@tackymt.homeip.net>
- A chicken is an egg's way of producing more eggs. -
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100501171252.e05f257f.taku>