Date: Fri, 3 Feb 2023 10:12:58 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Muhammad Moinur Rahman <bofh@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8607332fb826 - main - www/gitlab-pages: Fix bulk build warning Message-ID: <20230203091258.5ou4dpzklcp7euqj@aching.in.mat.cc> In-Reply-To: <202302022304.312N4C2R091641@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Feb 02, 2023 at 11:04:12PM +0000, Muhammad Moinur Rahman wrote: > The branch main has been updated by bofh: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=8607332fb8268becd08f7e6cfbc853bc76e2cc43 > > commit 8607332fb8268becd08f7e6cfbc853bc76e2cc43 > Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> > AuthorDate: 2023-02-02 23:01:36 +0000 > Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> > CommitDate: 2023-02-02 23:01:36 +0000 > > www/gitlab-pages: Fix bulk build warning > > In the previous commit a duplicate USE_FETCH target was added similar to > the one in Mk/Uses/go.mk. However this is possible using a different > number and target name compared to what is already predefined as it > conflicts. I fail to see the functional difference between this target and the existing one in USES=go, and it feels that now, the fetch is done twice, once in USES=go and once here. Can you try to see if it still works without this target here? > Reported by: bulk build > Approved by: portmgr (just-fix-it) > --- > www/gitlab-pages/Makefile | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/www/gitlab-pages/Makefile b/www/gitlab-pages/Makefile > index 9a97306037d6..da241eeec460 100644 > --- a/www/gitlab-pages/Makefile > +++ b/www/gitlab-pages/Makefile > @@ -1,5 +1,6 @@ > PORTNAME= gitlab-pages > PORTVERSION= 15.8.1 > +PORTREVISION= 1 > DISTVERSIONPREFIX= v > CATEGORIES= www > > @@ -29,8 +30,8 @@ MASTER_SITES+= https://gitlab.com/gitlab-org/gitlab-pages/-/raw/v${DISTVERSION}/ > DISTFILES+= go.mod > DIST_SUBDIR= go/${PKGORIGIN:S,/,_,g}/${DISTNAME} > EXTRACT_ONLY+= ${DISTFILES:N*.mod\:*:N*.mod:C/:.*//} > -_USES_fetch+= 800:go-post-fetch > -go-post-fetch: > +_USES_fetch+= 900:go-post-fetch-gitlab > +go-post-fetch-gitlab: > @${ECHO_MSG} "===> Fetching ${PORTNAME} dependencies"; > @(cd ${DISTDIR}/${DIST_SUBDIR}; \ > [ -e go.mod ] || ${RLN} ${GO_MODFILE} go.mod; \ > -- Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmPc0BpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb4adwv9GNJMeev4JFackCwT2s4JhKCqAws79vJI+1Jiq2FeYrgH6Om+uORrAEPB tsPhrDlKDWC49zX/p0abTqnT0kicuSOgjRIyZrs4zwealTXlvOeWGnTg05Mt4Zw0 52FmEy0Ct36Lp2c27Eqlw4fEXHrAQrn4+F+34wYyDI6v643NhQ6edDdk/XLf2CiS E9kTK5iEOx2NJmTrOzGigTVWY1AwCAnfuH8GkkNVpm0/h90fn1Xij16vEnCw9IFX skxcG9QpV6RdTRc+y6OD6sGEo0yShgOCRKrWTfbqKToHi5WJKXulZoYE8CWyF4ME /gdkZiYQAk94fn/YGLjnmQRiw6g5TW61yTFM1C8lQ2SnyaztCFVWb5cU9rIl2fzC ySo7gsGblW7aOcZMm20CrXpHjAWh8YQIP6etQouq2qz8b6NHAxICa4rKG5XHtkzH ejKf72wxDLs6VxbJJ+Pon25IQUKO/J4IBcNjtWgJHbuZFFn/Rr5NP8y0JtcSk1Q1 YAQnP0bo =FBDM -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230203091258.5ou4dpzklcp7euqj>