Date: Sun, 28 Nov 2004 21:14:34 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Michael Johnson <ahze@ahze.net> Cc: freebsd gnome <freebsd-gnome@freebsd.org> Subject: Re: libxklavier and upcoming xorg 6.8.1 upgrade Message-ID: <1101694474.49651.37.camel@shumai.marcuscom.com> In-Reply-To: <997800CC-41A5-11D9-BAC8-000A958C81C6@ahze.net> References: <200411290158.05194.dejan.lesjak@ijs.si> <36850935-41A4-11D9-BAC8-000A958C81C6@ahze.net> <DF88EC58-41A4-11D9-BAC8-000A958C81C6@ahze.net> <997800CC-41A5-11D9-BAC8-000A958C81C6@ahze.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-k1FgrY6Vce7WuTWYVOJU
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Sun, 2004-11-28 at 20:25 -0500, Michael Johnson wrote:
> On Nov 28, 2004, at 8:20 PM, Michael Johnson wrote:
>=20
> >
> > On Nov 28, 2004, at 8:15 PM, Michael Johnson wrote:
> >
> >>> Having no imake, this part fails and configure then checks if it=20
> >>> needs
> >>> additional flags for X. It already has -I${X11BASE}/include in=20
> >>> CPPFLAGS and
> >>> -L${X11BASE}/lib in LDFLAGS in environment, so it concludes that it=20
> >>> doesn't
> >>> need any and sets both $x_includes and $x_libraries to empty=20
> >>> strings. That
> >>> would be otherwise fine and the thing would bild. Unfortunately, it=20
> >>> uses the
> >>> value of $x_libraries to construct location of xkb specifications=20
> >>> without
> >>> further checks, and there it fails.
> >>> So for the solution: adding either=20
> >>> "--with-xkb-base=3D${X11BASE}/lib/X11/xkb" or
> >>> "--x-includes=3D${X11BASE}/include --x-libraries=3D${X11BASE}/lib" to
> >>> CONFIGURE_ARGS in ports Makefile should solve the problem.
> >>
> >> This brings up a good point, the lines in bsd.port.mk
> >>
> >> .if defined(USE_XLIB)
> >> LIB_DEPENDS+=3D X11.6:${X_LIBRARIES_PORT}
> >> # Add explicit X options to avoid problems with false positives in=20
> >> configure
> >> .if defined(GNU_CONFIGURE)
> >> CONFIGURE_ARGS+=3D--x-libraries=3D${X11BASE}/lib=20
> >> --x-includes=3D${X11BASE}/include
> >> .endif
> >> .endif
> >>
> >> Don't work with WITH_LIBTOOL_ since GNU_CONFIGURE is defined from=20
> >> bsd.autotools.mk
> >> should the previous not be a part of bsd.autotools.mk?
> >
> > Or moved in bsd.port.mk so it works with bsd.autotools.mk ?
>=20
> Like http://ahze.net/~ahze/bsd.port.mk.patch seems to work
Yeah, this looks okay. I wonder if Kris can add this to pointyhat as
part of the X.Org 6.8.1 build. If not, this should be turned into a PR
for future testing.
Joe
--=20
PGP Key : http://www.marcuscom.com/pgp.asc
--=-k1FgrY6Vce7WuTWYVOJU
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQBBqoYKb2iPiv4Uz4cRAlfHAJ4pLYD7/zcHIZjZcDmT04DBJfHXIACeK/tN
RiGjPDGn4+8i9r5iLZZu3yI=
=LIPq
-----END PGP SIGNATURE-----
--=-k1FgrY6Vce7WuTWYVOJU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1101694474.49651.37.camel>