Date: Wed, 5 Apr 2017 16:06:58 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Kyle Evans <kevans91@ksu.edu> Cc: Ed Maste <emaste@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r316536 - in head: contrib/netbsd-tests/usr.bin/grep usr.bin/grep/tests Message-ID: <B00617D5-CF98-44B6-A8B9-BB0CC8536954@gmail.com> In-Reply-To: <CACNAnaE6=CE9NkVSvtG8ezQZL8d58FXM=wAht-pcVa7fE6U7mw@mail.gmail.com> References: <201704051841.v35IfiP2009466@repo.freebsd.org> <85B65B02-8146-449C-B003-B375B8EE3F43@gmail.com> <CACNAnaE6=CE9NkVSvtG8ezQZL8d58FXM=wAht-pcVa7fE6U7mw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
> On Apr 5, 2017, at 12:33, Kyle Evans <kevans91@ksu.edu> wrote:
>
> On Wed, Apr 5, 2017 at 1:48 PM, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote:
>
> As a general rule of thumb, if it doesn’t pass, it needs to be marked as an expected failure until it passes. Not really a big deal right now (because ci.freebsd.org isn’t spamming current@ — yet), but when that switch gets thrown again, it would spam a few hundred people with known failures.
>
> Ah, whoops. Something like this?
>
> diff --git a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
> index b8d2a398c8d..189e3547e34 100755
> --- a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
> +++ b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
> @@ -234,6 +234,7 @@ oflag_zerolen_head()
> }
> oflag_zerolen_body()
> {
> + atf_expect_fail "GNU grep's -o behavior with empty matches has known bugs (PR 195763)"
> atf_check -o file:"$(atf_get_srcdir)/d_oflag_zerolen_a.out" \
> grep -Eo '(^|:)0*' "$(atf_get_srcdir)/d_oflag_zerolen_a.in"
>
> @@ -281,6 +282,7 @@ color_body()
> atf_check -o file:"$(atf_get_srcdir)/d_color_b.out" \
> grep --color=auto -f grepfile "$(atf_get_srcdir)/d_color_b.in"
>
> + atf_expect_fail "GNU grep --color output does not exactly match expectations going forward"
> atf_check -o file:"$(atf_get_srcdir)/d_color_c.out" \
> grep --color=always -f grepfile "$(atf_get_srcdir)/d_color_b.in"
> }
>
> <grep-fail-tests.diff>
Yup!
-Ngie
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJY5XiTAAoJEPWDqSZpMIYVE8AP/j6LDS8DTRGI3D3D5mEAOHZs
/IbMbExEYqFMUONybA6YBiwnuIs6LnX6rJl9kLIR373KXZcRwZZyp98AKBZIvQ4S
zKdauwNFCJHBs6hRaNcn+IBgIsJV4mMfN6uRHG1Uu/gCVSR7vazkpxbmT9QHj95Z
CLeK5Qvlq93jioQScXHCMRVs1AlQqsWhmMVuTuGNSArYzETlbDH52PxU5J3DjiUg
+p3owpQEjy5BZ2kw4wmxomF4Ls37qRycH/UaIDO5WWs70N05dLeZxOphyjvPQBcg
cmQ/oEZYC6peU6by/4QXhM+yCmdErDlYdfsrCKUSXjKjj+6H4rwWCEo/eGrdAJRL
Cmwc5Ckc57aucgQvvshtkOr2P62iPqS//tmZGVREx6gA2zJi6/OzssSiBcRFTSUo
5LLvaSg7Gkpyjad++HzKk6p3hJ/BgNwoG8jIbdChYvVg5W/LJeT9lcUH7zpL31Ar
/jIX/YHNy+ZBtN7VPNHK4UHJSs+KYXh0PjHMqJn0MYxMlF15iaU63EMUIXDWzAfu
o0dT15O51a0AqiMPJbdkL1m9Qg0K9qGz5J07dGwUWDh3MQwydONhWlsniOtf/V0I
2YFna7McFTs9I9qt7jxMT3RUOmz9aguNVn1xjNyZPi7PHBkRHhikChz0PZGLqebs
ss5+2RRVCIVCrCJM8kzm
=dJ4C
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B00617D5-CF98-44B6-A8B9-BB0CC8536954>