Date: Mon, 6 May 2019 22:31:56 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Dmitry Chagin <dchagin@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347218 - head/sys/compat/linsysfs Message-ID: <201905070531.x475VuIY010069@gndrsh.dnsmgr.net> In-Reply-To: <201905070508.x4758DW5015688@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: dchagin > Date: Tue May 7 05:08:13 2019 > New Revision: 347218 > URL: https://svnweb.freebsd.org/changeset/base/347218 > > Log: > Remove wrong copyright line. Discussed with Carlos Neira. > > Reported by: Rodney W. Grimes normally just use a committers username, aka rgrimes or rgrimes@ for these types of things. > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D13656 Hang on, now you removed his copyright? I see he said that was ok, but that was not the desired intent here. It would of been fine to have the copyright read: * Copyright (c) 2006 IronPort Systems * All rights reserved. * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com As a heads up to other committers you should never insert your copyright between another copyright and the "All rights reserved." text, if you wish to assert the all rights reserved you should duplicate it like: * Copyright (c) 2006 IronPort Systems * All rights reserved. * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com * All rights reserved. preferably on the line with your copyright as in: * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com All rights reserved. But if at all possible it would be best if we could not add any more of these, and remove them when possible. For those wishing to save space the (c) is unneeded when you spell out the word "Copyright". > > Modified: > head/sys/compat/linsysfs/linsysfs.c > > Modified: head/sys/compat/linsysfs/linsysfs.c > ============================================================================== > --- head/sys/compat/linsysfs/linsysfs.c Tue May 7 01:27:23 2019 (r347217) > +++ head/sys/compat/linsysfs/linsysfs.c Tue May 7 05:08:13 2019 (r347218) > @@ -2,7 +2,6 @@ > * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > * > * Copyright (c) 2006 IronPort Systems > - * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com > * All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905070531.x475VuIY010069>