Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Aug 2006 10:31:33 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        freebsd-current@freebsd.org
Cc:        Ian FREISLICH <if@hetzner.co.za>, Gleb Smirnoff <glebius@freebsd.org>, Andrew Thompson <thompsa@freebsd.org>
Subject:   Re: 802.1Q vlan performance. [PATCH]
Message-ID:  <200608251031.34081.jhb@freebsd.org>
In-Reply-To: <20060825101140.GV76666@FreeBSD.org>
References:  <E1GGYM0-000CVd-1K@hetzner.co.za> <E1GGYY5-000CYz-Ow@hetzner.co.za> <20060825101140.GV76666@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 25 August 2006 06:11, Gleb Smirnoff wrote:
> On Fri, Aug 25, 2006 at 12:04:25PM +0200, Ian FREISLICH wrote:
> I> > Alternatively is there an objection to making this a kernel
> I> > configuration file option as opposed to leaving it as an undocumented
> I> > buried treasure?
> I> 
> I> I see it is an option, just undocumented.
> I> 
> I> Whitespace mangled:
> I> 
> I> RCS file: /home/ncvs/src/sys/conf/NOTES,v
> I> retrieving revision 1.1378
> I> diff -u -d -r1.1378 NOTES
> I> --- /usr/src/sys/conf/NOTES       17 Aug 2006 00:37:03 -0000      1.1378
> I> +++ /usr/src/sys/conf/NOTES       25 Aug 2006 10:03:18 -0000
> I> @@ -646,6 +646,7 @@
> I>  #
> I>  device         ether                   #Generic Ethernet
> I>  device         vlan                    #VLAN support (needs miibus)
> I> +options                VLAN_ARRAY              #Lookup table for trunk interface
> I>  device         wlan                    #802.11 support
> I>  device         wlan_wep                #802.11 WEP support
> I>  device         wlan_ccmp               #802.11 CCMP support
> 
> I'd prefer not to put it into NOTES. When enabled, less code will
> be covered by LINT.

Bah, GENERIC will cover it then.  All options should be in NOTES.  If
an option removes code and it's enabled in GENERIC, then you should put
it in NOTES but comment it out.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608251031.34081.jhb>