Date: Thu, 31 Dec 2015 18:15:37 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292987 - in head/sys/compat/linuxkpi/common: include/linux src Message-ID: <1F2A43B0-6A36-4C8C-B09C-5BA66B3BFE6C@FreeBSD.org> In-Reply-To: <201512311230.tBVCUJB7094023@repo.freebsd.org> References: <201512311230.tBVCUJB7094023@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 31 Dec 2015, at 12:30 , Hans Petter Selasky <hselasky@FreeBSD.org> wrote: > > Author: hselasky > Date: Thu Dec 31 12:30:19 2015 > New Revision: 292987 > URL: https://svnweb.freebsd.org/changeset/base/292987 > > Log: > Minor LinuxKPI code cleanup: > - Declare some static functions in linux_compat.c instead if inside > various header files. > - Prefix FreeBSD local functions in the LinuxKPI with "linux_" to > avoid symbol name conflicts in the future and to make debugging > easier. > - Make the "struct kobj_ktype" declaractions constant to shave off a > few bytes from the data segment. > > MFC after: 1 week > Sponsored by: Mellanox Technologies > > Modified: > head/sys/compat/linuxkpi/common/include/linux/cdev.h > head/sys/compat/linuxkpi/common/include/linux/device.h > head/sys/compat/linuxkpi/common/include/linux/kobject.h > head/sys/compat/linuxkpi/common/include/linux/miscdevice.h > head/sys/compat/linuxkpi/common/src/linux_compat.c > head/sys/compat/linuxkpi/common/src/linux_pci.c I can only guess if it was this commit? This is i386.LINT* erroring (but there might be other kernels as well; don’t know yet): linking kernel cm.o: In function `ib_cm_init': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/cm.c:(.text+0x81f5): undefined reference to `class_root' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/cm.c:(.text+0x827d): undefined reference to `kobject_release' cm.o: In function `cm_add_one': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/cm.c:(.text+0x864f): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/cm.c:(.text+0x868f): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/cm.c:(.text+0x885c): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/cm.c:(.text+0x8893): undefined reference to `kobject_release' cm.o:/scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/cm.c:(.text+0x88d3): more undefined references to `kobject_release' follow sysfs.o: In function `ib_device_register_sysfs': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/sysfs.c:(.text+0x489): undefined reference to `kfree_type' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/sysfs.c:(.text+0x4e5): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/sysfs.c:(.text+0x5f5): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/sysfs.c:(.text+0x63b): undefined reference to `kobject_release' sysfs.o: In function `add_port': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/sysfs.c:(.text+0xf3e): undefined reference to `kobject_release' sysfs.o: In function `device_unregister': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/sysfs.c:(.text+0x1051): undefined reference to `kobject_release' sysfs.o:/scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/sysfs.c:(.text+0x1254): more undefined references to `kobject_release' follow sysfs.o: In function `ib_sysfs_setup': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/sysfs.c:(.text+0x145a): undefined reference to `class_root' sysfs.o: In function `ib_sysfs_cleanup': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/sysfs.c:(.text+0x14be): undefined reference to `kobject_release' ucm.o: In function `ib_ucm_remove_one': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/ucm.c:(.text+0x7e4): undefined reference to `kobject_release' ucm.o: In function `ib_ucm_release_dev': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/ucm.c:(.text+0x86c): undefined reference to `kobject_release' ucma.o: In function `ucma_init': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/ucma.c:(.text+0x140): undefined reference to `linux_rootdev' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/ucma.c:(.text+0x147): undefined reference to `miscclass' ucma.o: In function `misc_deregister': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/ucma.c:(.text+0x301): undefined reference to `miscclass' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/ucma.c:(.text+0x3bc): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/ucma.c:(.text+0x40b): undefined reference to `kobject_release' user_mad.o: In function `ib_umad_init': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/user_mad.c:(.text+0x1d7): undefined reference to `class_root' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/user_mad.c:(.text+0x2fd): undefined reference to `kobject_release' user_mad.o: In function `ib_umad_add_one': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/user_mad.c:(.text+0xf6e): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/user_mad.c:(.text+0xfd0): undefined reference to `kobject_release' user_mad.o: In function `put_umad_dev': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/user_mad.c:(.text+0x1458): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/user_mad.c:(.text+0x14a8): undefined reference to `kobject_release' user_mad.o:/scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/user_mad.c:(.text+0x15f2): more undefined references to `kobject_release' follow uverbs_main.o: In function `ib_uverbs_init': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/uverbs_main.c:(.text+0x10de): undefined reference to `class_root' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/uverbs_main.c:(.text+0x1204): undefined reference to `kobject_release' uverbs_main.o: In function `ib_uverbs_add_one': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/uverbs_main.c:(.text+0x1b0f): undefined reference to `kobject_release' uverbs_main.o: In function `ib_uverbs_remove_one': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/uverbs_main.c:(.text+0x1cc2): undefined reference to `kobject_release' uverbs_main.o: In function `device_destroy': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/uverbs_main.c:(.text+0x1e92): undefined reference to `kobject_release' uverbs_main.o: In function `ib_uverbs_cleanup': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/core/uverbs_main.c:(.text+0x32a6): undefined reference to `kobject_release' mlx4ib_sysfs.o:/scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/hw/mlx4/sysfs.c:(.text+0x755): more undefined references to `kobject_release' follow mlx4ib_sysfs.o: In function `kobject_create_and_add': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/hw/mlx4/sysfs.c:(.text+0x1417): undefined reference to `kfree_type' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/hw/mlx4/sysfs.c:(.text+0x146a): undefined reference to `kobject_release' mlx4ib_sysfs.o: In function `mlx4_ib_device_unregister_sysfs': /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/hw/mlx4/sysfs.c:(.text+0x1635): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/hw/mlx4/sysfs.c:(.text+0x166e): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/hw/mlx4/sysfs.c:(.text+0x16a7): undefined reference to `kobject_release' /scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/hw/mlx4/sysfs.c:(.text+0x16df): undefined reference to `kobject_release' mlx4ib_sysfs.o:/scratch/tmp/bz/head.svn/sys/ofed/drivers/infiniband/hw/mlx4/sysfs.c:(.text+0x1718): more undefined references to `kobject_release' follow --- kernel --- *** [kernel] Error code 1 — Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1F2A43B0-6A36-4C8C-B09C-5BA66B3BFE6C>