Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 3 Jun 2006 01:55:55 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Craig Rodrigues <rodrigc@crodrigues.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern vfs_mount.c
Message-ID:  <20060602235555.GA55243@garage.freebsd.pl>
In-Reply-To: <20060602222536.GA45547@crodrigues.org>
References:  <200606022029.k52KT2el024554@repoman.freebsd.org> <20060602222536.GA45547@crodrigues.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--3MwIy2ne0vdjdPXF
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 02, 2006 at 06:25:36PM -0400, Craig Rodrigues wrote:
+> On Fri, Jun 02, 2006 at 08:29:02PM +0000, Pawel Jakub Dawidek wrote:
+> > pjd         2006-06-02 20:29:02 UTC
+> >=20
+> >   FreeBSD src repository
+> >=20
+> >   Modified files:
+> >     sys/kern             vfs_mount.c=20
+> >   Log:
+> >   Fix a problem introduced in revision 1.220. On mount(2) failure, don=
't
+> >   forget to unbusy file system before its destruction.
+> >  =20
+> >   This fixes the following warning on mount failure:
+> >  =20
+> >           Mount point <X> had 1 dangling refs
+> >  =20
+> >   Tested by:      wkoszek
+> >  =20
+> >   Revision  Changes    Path
+> >   1.226     +6 -5      src/sys/kern/vfs_mount.c
+>=20
+>=20
+> Does this problem fix the slight delay that you get when
+> doing a mount or update mount with a bad mount option?
+>=20
+> For example:
+>=20
+> mount -u -o nonexistentopt /mymount

Yes, vfs_mount_destroy() waits 3 seconds if there is a dangling
reference. Now there is no such reference when the function is called.

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--3MwIy2ne0vdjdPXF
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)

iD8DBQFEgNALForvXbEpPzQRAupyAKDXXTCFmPE0syUVzT7F5+/iVvNZcgCgj6wh
WjxNns7KoFDETtqH0q30RLY=
=8/Z2
-----END PGP SIGNATURE-----

--3MwIy2ne0vdjdPXF--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060602235555.GA55243>