Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Jul 2010 19:51:49 +1000 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Kai Wang <kaiw@FreeBSD.org>
Subject:   Re: svn commit: r210321 - head/lib/libelf
Message-ID:  <20100721194659.L7533@delplex.bde.org>
In-Reply-To: <20100721090623.GA21607@FreeBSD.org>
References:  <201007210843.o6L8hmo5064622@svn.freebsd.org> <20100721090623.GA21607@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 21 Jul 2010, Alexey Dokuchaev wrote:

> On Wed, Jul 21, 2010 at 08:43:48AM +0000, Kai Wang wrote:
>> Log:
>>   Remove a superfluous comment.
>>
>>   Obtained from:	     elftoolchain
>>   MFC after:	     1 month
>
> (Just picking random of the similar commits): guys, please, try to
> uniformly align commit meta tags:

It is perfectly aligned with tabs (and no 2-char commit mail indentation,
and no N-char mailer quoting).

> Obtained from:	somewhere
> MFC after:	sometime
> Foo bar:	baz qux ...
>
> Broken alignment considerably pessimizes commit log grasping, as it
> requires more post-processing work after reading it off.

Do you mean for human grasping and automated post-processing?  The automation
should have no problems with the whitespace but might with the mailer quoting.

"tags" should mean the part before the ":".  Aligning those by making them
all of the same length would help.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100721194659.L7533>