Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Apr 2017 08:40:45 -0700
From:      Conrad Meyer <cem@freebsd.org>
To:        Konstantin Belousov <kib@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r316851 - head/sys/x86/iommu
Message-ID:  <CAG6CVpVadTHSLYv7ZW7XVXs4LdOP-F979aSOXC_fwnCW2Wi6bA@mail.gmail.com>
In-Reply-To: <201704141516.v3EFGgK9087765@repo.freebsd.org>
References:  <201704141516.v3EFGgK9087765@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 14, 2017 at 8:16 AM, Konstantin Belousov <kib@freebsd.org> wrote:
> Author: kib
> Date: Fri Apr 14 15:16:41 2017
> New Revision: 316851
> URL: https://svnweb.freebsd.org/changeset/base/316851
>
> Log:
>   Correct calculation of the entry->free_down in the invariants-checking
>   code.
>
>   Reported by:  maxim
>   Found by:     PVS studio scan


This was also reported by Coverity in CID 1304880 as an unused value.

Coverity also reports a NULL check (l. 547) after all paths have
dereferenced the pointer ("next") already in dmar_gas_alloc_region()
of the same file (CID 1199386).

Best,
Conrad



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpVadTHSLYv7ZW7XVXs4LdOP-F979aSOXC_fwnCW2Wi6bA>