Date: Tue, 15 Oct 2013 10:04:03 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: sbruno@freebsd.org Cc: freebsd-embedded@freebsd.org Subject: Re: makefs(8) proposed changes [repost from fs@] Message-ID: <20131015170403.GO56872@funkthat.com> In-Reply-To: <1381853252.2682.0.camel@localhost> References: <1380730546.1619.47.camel@localhost> <1381853252.2682.0.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
Sean Bruno wrote this message on Tue, Oct 15, 2013 at 09:07 -0700:
> Is this patch going to break non "device" makefs calls? e.g. if I want
> to create an image file and not use a loopback device?
If the image file is zero bytes, then yes, it will break it... as the
read will return a short value (possibly zero) ... Why not add some
error checking and if the read doesn't read enough, write the
remaining bytes? If there is a failure from the read, the operation
should fail...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131015170403.GO56872>