Date: Tue, 3 Mar 2009 14:21:06 -0500 From: Alexander Kabaev <kabaev@gmail.com> To: Ed Schouten <ed@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189315 - in head/sys/netgraph: . atm Message-ID: <20090303142106.0ee73d35@kan.dnsalias.net> In-Reply-To: <200903031847.n23IlX7N018454@svn.freebsd.org> References: <200903031847.n23IlX7N018454@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/XA3xMmQCB9EVQono.sATloK Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 3 Mar 2009 18:47:33 +0000 (UTC) Ed Schouten <ed@FreeBSD.org> wrote: > Author: ed > Date: Tue Mar 3 18:47:33 2009 > New Revision: 189315 > URL: http://svn.freebsd.org/changeset/base/189315 >=20 > Log: > Make Netgraph compile with Clang. > =20 > Clang disallows structs with variable length arrays to be nested > inside other structs, because this is in violation with ISO C99. Even > though we can keep bugging the LLVM folks about this issue, we'd > better just fix our code to not do this. This code seems to be the > only code in the entire source tree that does this. > =20 > I haven't tested this patch by using the kernel modules in > question, but Diane Bruce and I have compared disassembled versions > of these kernel modules. We would have expected them to be exactly > the same, but due to randomness in the register allocator and > reordering of instructions, there were some minor differences. > =20 > Approved by: julian >=20 > Modified: > head/sys/netgraph/atm/ng_ccatm.h > head/sys/netgraph/ng_pppoe.c > head/sys/netgraph/ng_pppoe.h Hi, I hope I am not the only one to see this as a code regression from the code readability viewpoint. I think obfuscation of our sources just to bow to yet another head-strong compiler should stop. If LLVM cannot parse common code constructs, LLVM is NOT suitable for our kernel no matter how many paragraphs of language-lawyer-speak they use to justify it.=20 --=20 Alexander Kabaev --Sig_/XA3xMmQCB9EVQono.sATloK Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFJrYMiQ6z1jMm+XZYRAm/UAJ9WsPSwAv+tXFp087qPla64M+IXbgCgg9iN GxYKPlhQKOsp9fZG1eGQXIM= =/7ko -----END PGP SIGNATURE----- --Sig_/XA3xMmQCB9EVQono.sATloK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090303142106.0ee73d35>