Date: Mon, 15 Jan 2018 20:40:11 +0000 (UTC) From: Kyle Evans <kevans@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r459112 - in head/devel/bossa: . files Message-ID: <201801152040.w0FKeBKx048699@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kevans (src committer) Date: Mon Jan 15 20:40:11 2018 New Revision: 459112 URL: https://svnweb.freebsd.org/changeset/ports/459112 Log: devel/bossa: Fix build after recent Clang update on -HEAD Clang 6 caught a bogus comparison that was not previously caught; fix the build by correcting the comparison to correctly dereference the `char *` before comparing it with '\0'. PORTREVISION bumped because the comparison was erroneous and still successfully built everywhere but -HEAD. This patch is effectively from upstream. It will go away with the update to BOSSA 1.8, which requires a little more testing still. Approved by: antoine Added: head/devel/bossa/files/patch-src_Command.cpp (contents, props changed) Modified: head/devel/bossa/Makefile Modified: head/devel/bossa/Makefile ============================================================================== --- head/devel/bossa/Makefile Mon Jan 15 20:13:22 2018 (r459111) +++ head/devel/bossa/Makefile Mon Jan 15 20:40:11 2018 (r459112) @@ -2,7 +2,7 @@ PORTNAME= bossa PORTVERSION= 1.7.0 -PORTREVISION= 4 +PORTREVISION= 5 CATEGORIES= devel MAINTAINER= kevans@FreeBSD.org Added: head/devel/bossa/files/patch-src_Command.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/bossa/files/patch-src_Command.cpp Mon Jan 15 20:40:11 2018 (r459112) @@ -0,0 +1,20 @@ +--- src/Command.cpp.orig 2018-01-15 20:28:09 UTC ++++ src/Command.cpp +@@ -674,7 +674,7 @@ CommandMwb::invoke(char* argv[], int argc) + char* input = readline("? "); + if (!input) + return; +- if (input == '\0' || ++ if (*input == '\0' || + !argUint32(input, &value)) + { + free(input); +@@ -777,7 +777,7 @@ CommandMww::invoke(char* argv[], int argc) + char* input = readline("? "); + if (!input) + return; +- if (input == '\0' || ++ if (*input == '\0' || + !argUint32(input, &value)) + { + free(input);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801152040.w0FKeBKx048699>