Date: Tue, 14 Nov 2023 10:58:51 +0000 From: Doug Rabson <dfr@rabson.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: pkgbase@freebsd.org, re <re@freebsd.org> Subject: Re: Package version for 14.0-RELEASE Message-ID: <CACA0VUioVj-ymzceT8YsHJpOyagCLjaYF_gqFWYq_eDLiDRo9Q@mail.gmail.com> In-Reply-To: <jqmeoiu4atbmdzjhpltl7vhq6ph5lvbrtqq6jo3d4eumiip7vn@tcmchh4da5e3> References: <CACA0VUjMQ24Nn7Hb2fmz8QsqbwWviYBjwbv4Sg-E=RhM3_zDhw@mail.gmail.com> <CACA0VUivCQVagjPhBWGxC_uiZ3_EuJ0j=rKS-9hFdi5aFpx0-A@mail.gmail.com> <CACA0VUhRv9nqt%2B06dg%2Bz8L-f6rmJdonG0EZ2yVx5_-sv72zLsg@mail.gmail.com> <CACA0VUiZJGUUOyN-%2BvM5i%2BrCH6AeoG=WOMFNkiXhrZcqi=ZBgA@mail.gmail.com> <jqmeoiu4atbmdzjhpltl7vhq6ph5lvbrtqq6jo3d4eumiip7vn@tcmchh4da5e3>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Tue, 14 Nov 2023 at 10:48, Baptiste Daroussin <bapt@freebsd.org> wrote:
> On Tue, Nov 14, 2023 at 10:08:59AM +0000, Doug Rabson wrote:
> > On Mon, 13 Nov 2023 at 08:43, Doug Rabson <dfr@rabson.org> wrote:
> >
> > >
> > >
> > > On Sat, 11 Nov 2023 at 16:26, Doug Rabson <dfr@rabson.org> wrote:
> > >
> > >>
> > >>
> > >> On Sat, 11 Nov 2023 at 09:52, Doug Rabson <dfr@rabson.org> wrote:
> > >>
> > >>> I think there is a problem with the pkgbase package versions for
> > >>> 14.0-RELEASE. Looking at my overnight builds and comparing
> releng/14.0 with
> > >>> releng/13.2, I see that the package versions for 14 don't include
> the minor
> > >>> revision:
> > >>>
> > >>> # ls -l releng/13.2/repo/FreeBSD:13:amd64/latest/FreeBSD-runtime-13*
> > >>> -rw-r--r-- 1 root wheel 3485868 Nov 10 22:39
> > >>> releng/13.2/repo/FreeBSD:13:amd64/latest/FreeBSD-runtime-13.2p5.pkg
> > >>> # ls -l releng/14.0/repo/FreeBSD:14:amd64/latest/FreeBSD-runtime-14*
> > >>> -rw-r--r-- 1 root wheel 3342388 Nov 10 21:54
> > >>> releng/14.0/repo/FreeBSD:14:amd64/latest/FreeBSD-runtime-14.pkg
> > >>> r
> > >>>
> > >>>
> > >>> I think the minor revision gets lost, possibly in the part of
> > >>> release/Makefile that parses out the REVISION variable from
> newvers.sh.
> > >>>
> > >>> I'm not sure if this is a problem but it's certainly surprising.
> > >>>
> > >>
> > >> Comparing 13.2 and 14.0, in 13.2, PKG_VERSION is defined as:
> > >>
> > >> PKG_VERSION:= ${_REVISION}${EXTRA_REVISION:C/[[:space:]]//g}
> > >>
> > >>
> > >> where _REVISION is "13.2".
> > >>
> > >> In 14.0, it is:
> > >>
> > >> PKG_VERSION:= ${MAJOR_REVISION}${EXTRA_REVISION:C/[[:space:]]//g}
> > >>
> > >>
> > >> where _REVISION is "14.0" and MAJOR_REVISION is ${_REVISION:R} which
> is
> > >> "14".
> > >>
> > >> Perhaps it should change back?
> > >>
> > >
> > > I opened https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275051 to
> > > track this problem.
> > >
> >
> > I think we should consider this for a FreeBSD 14.0 errata so that
> packages
> > built for 14.0-RELEASE-p1 and later can have the correct version numbers.
> > I've started drafting an errata notice and I will merge the fix to
> > stable/14 before the end of this week.
> >
> > Doug.
>
> Yes I think this should deserves an errata, but actually there are for sure
> other things that should come along with it, so maybe we should make a big
> errata all at once in the next couple of month.
>
That makes sense - after all, this is a metadata problem and the OS itself
is not affected.
Doug.
[-- Attachment #2 --]
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 14 Nov 2023 at 10:48, Baptiste Daroussin <<a href="mailto:bapt@freebsd.org">bapt@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On Tue, Nov 14, 2023 at 10:08:59AM +0000, Doug Rabson wrote:<br>
> On Mon, 13 Nov 2023 at 08:43, Doug Rabson <<a href="mailto:dfr@rabson.org" target="_blank">dfr@rabson.org</a>> wrote:<br>
> <br>
> ><br>
> ><br>
> > On Sat, 11 Nov 2023 at 16:26, Doug Rabson <<a href="mailto:dfr@rabson.org" target="_blank">dfr@rabson.org</a>> wrote:<br>
> ><br>
> >><br>
> >><br>
> >> On Sat, 11 Nov 2023 at 09:52, Doug Rabson <<a href="mailto:dfr@rabson.org" target="_blank">dfr@rabson.org</a>> wrote:<br>
> >><br>
> >>> I think there is a problem with the pkgbase package versions for<br>
> >>> 14.0-RELEASE. Looking at my overnight builds and comparing releng/14.0 with<br>
> >>> releng/13.2, I see that the package versions for 14 don't include the minor<br>
> >>> revision:<br>
> >>><br>
> >>> # ls -l releng/13.2/repo/FreeBSD:13:amd64/latest/FreeBSD-runtime-13*<br>
> >>> -rw-r--r-- 1 root wheel 3485868 Nov 10 22:39<br>
> >>> releng/13.2/repo/FreeBSD:13:amd64/latest/FreeBSD-runtime-13.2p5.pkg<br>
> >>> # ls -l releng/14.0/repo/FreeBSD:14:amd64/latest/FreeBSD-runtime-14*<br>
> >>> -rw-r--r-- 1 root wheel 3342388 Nov 10 21:54<br>
> >>> releng/14.0/repo/FreeBSD:14:amd64/latest/FreeBSD-runtime-14.pkg<br>
> >>> r<br>
> >>><br>
> >>><br>
> >>> I think the minor revision gets lost, possibly in the part of<br>
> >>> release/Makefile that parses out the REVISION variable from newvers.sh.<br>
> >>><br>
> >>> I'm not sure if this is a problem but it's certainly surprising.<br>
> >>><br>
> >><br>
> >> Comparing 13.2 and 14.0, in 13.2, PKG_VERSION is defined as:<br>
> >><br>
> >> PKG_VERSION:= ${_REVISION}${EXTRA_REVISION:C/[[:space:]]//g}<br>
> >><br>
> >><br>
> >> where _REVISION is "13.2".<br>
> >><br>
> >> In 14.0, it is:<br>
> >><br>
> >> PKG_VERSION:= ${MAJOR_REVISION}${EXTRA_REVISION:C/[[:space:]]//g}<br>
> >><br>
> >><br>
> >> where _REVISION is "14.0" and MAJOR_REVISION is ${_REVISION:R} which is<br>
> >> "14".<br>
> >><br>
> >> Perhaps it should change back?<br>
> >><br>
> ><br>
> > I opened <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275051" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275051</a>; to<br>
> > track this problem.<br>
> ><br>
> <br>
> I think we should consider this for a FreeBSD 14.0 errata so that packages<br>
> built for 14.0-RELEASE-p1 and later can have the correct version numbers.<br>
> I've started drafting an errata notice and I will merge the fix to<br>
> stable/14 before the end of this week.<br>
> <br>
> Doug.<br>
<br>
Yes I think this should deserves an errata, but actually there are for sure<br>
other things that should come along with it, so maybe we should make a big<br>
errata all at once in the next couple of month.<br></blockquote><div><br></div><div>That makes sense - after all, this is a metadata problem and the OS itself is not affected.</div><div><br></div><div>Doug. </div></div></div>
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACA0VUioVj-ymzceT8YsHJpOyagCLjaYF_gqFWYq_eDLiDRo9Q>