Date: Sun, 26 Mar 2023 17:45:07 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: "Alexander V. Chernikov" <melifaro@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a85dcd4ac4b0 - main - netlink: restrict default userland switch to netlink to i386/amd64. Message-ID: <486C839F-181F-4CE8-8510-4A7D4D100FDC@freebsd.org> In-Reply-To: <CAPyFy2Bdhi7xWs9-5JzudbVj62GarWeeJ9BwBEK=0smvcT2Dgw@mail.gmail.com> References: <202303261107.32QB7T7N058867@gitrepo.freebsd.org> <CAPyFy2Bdhi7xWs9-5JzudbVj62GarWeeJ9BwBEK=0smvcT2Dgw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26 Mar 2023, at 17:17, Ed Maste <emaste@freebsd.org> wrote: >=20 >=20 > On Sun, 26 Mar 2023 at 07:07, Alexander V. Chernikov > <melifaro@freebsd.org> wrote: >>=20 >> The branch main has been updated by melifaro: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Da85dcd4ac4b0612b63b5a71eeaaa707a= 09ae0003 >>=20 >> commit a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003 >> Author: Alexander V. Chernikov <melifaro@FreeBSD.org> >> AuthorDate: 2023-03-26 11:05:21 +0000 >> Commit: Alexander V. Chernikov <melifaro@FreeBSD.org> >> CommitDate: 2023-03-26 11:06:53 +0000 >>=20 >> netlink: restrict default userland switch to netlink to = i386/amd64. >=20 > We should keep default options the same for all Tier-1 architectures, > so amd64 and arm64 should be in sync. But also, what=E2=80=99s the technical justification for this change? = There should not be gratuitous differences between architectures like this, only when there is a reason something shouldn=E2=80=99t be enabled. Why = should x86 (and possibly arm64) get netlink, but not arm/powerpc/riscv? We have very few machine-dependent defaults in src.opts.mk. If there is no such justification then please revert this in its entirety, and if there is such a justification it belongs in a comment above the if. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?486C839F-181F-4CE8-8510-4A7D4D100FDC>