Date: Mon, 14 Feb 2005 20:14:31 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: Sam Leffler <sam@errno.com> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c Message-ID: <20050214181431.GA69635@ip.net.ua> In-Reply-To: <4210D210.3080700@errno.com> References: <200502140829.j1E8TgDs086634@repoman.freebsd.org> <4210D210.3080700@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--sm4nu43k4a2Rpi4c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Sam, On Mon, Feb 14, 2005 at 08:30:08AM -0800, Sam Leffler wrote: > Ruslan Ermilov wrote: > >ru 2005-02-14 08:29:42 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/net if_ethersubr.c=20 > > Log: > > If no vlan(4) interfaces are configured for the interface, and the > > driver did VLAN decapsulation in hardware, we were passing a frame > > as if it came for the parent (non-VLAN) interface. Stop this from > > happening. > > =20 > > Reminded by: glebius > > Security: This could pose a security risk in some setups > > =20 > > Revision Changes Path > > 1.183 +10 -3 src/sys/net/if_ethersubr.c > >http://cvsweb.FreeBSD.org/src/sys/net/if_ethersubr.c.diff?r1=3D1.182&r2= =3D1.183 > > > > > Looks like you should use m_tag_find instead of=20 > m_tag_first+m_tag_locate. >=20 Unfortunately m_tag_find() is only the compatibility function and doesn't work for FreeBSD mtags. > This also has the potential to noticeably=20 > affect performance so I think a better solution is needed. >=20 Here are my thoughts. On a typical input path, there will be either one or zero mtags, one if driver provided us with the VLAN mtag, so effectively we replaced "ifp->if_nvlans" with "m_tag_first(m) !=3D NULL", and this doesn't look like a huge performance downgrade to me, if at all. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --sm4nu43k4a2Rpi4c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFCEOqHqRfpzJluFF4RAvNoAJ9a0t1AgPeC2/1/OnHfhPirkRDtCwCdGYsc diiw64qY6xFXbgIW75ksxmA= =N8Sj -----END PGP SIGNATURE----- --sm4nu43k4a2Rpi4c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050214181431.GA69635>