Date: Mon, 21 Jun 2010 15:47:24 +0200 From: Rafal Jaworowski <raj@semihalf.com> To: Kristof Provost <kristof@sigsegv.be> Cc: freebsd-arm@FreeBSD.org, Alexander Motin <mav@FreeBSD.org>, Warner Losh <imp@FreeBSD.org>, Norikatsu Shigemura <nork@FreeBSD.org> Subject: Re: OpenRD-Client/Ultimate support Message-ID: <4AD04D0B-C12C-4909-8BAB-533D7B60157A@semihalf.com> In-Reply-To: <20100621131830.GF31846@nereid> References: <20100620220302.8eb84547.nork@FreeBSD.org> <B070D797-2CEE-437F-A835-0AD39E7593E8@semihalf.com> <20100621123239.GD31846@nereid> <79FA8A01-E855-405B-B967-BF2BF972DD2D@semihalf.com> <20100621131830.GF31846@nereid>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2010-06-21, at 15:18, Kristof Provost wrote:
> On 2010-06-21 14:46:02 (+0200), Rafal Jaworowski <raj@semihalf.com> =
wrote:
>>=20
>> On 2010-06-21, at 14:32, Kristof Provost wrote:
>>=20
>>> On 2010-06-21 14:08:47 (+0200), Rafal Jaworowski <raj@semihalf.com> =
wrote:
>>>>=20
>>>> On 2010-06-20, at 15:03, Norikatsu Shigemura wrote:
>>>>> 2. Change how to set PHY numbers.
>>>>> Suggested by: Kristof Provost
>>>>=20
>>>> Please elaborate on what is being fixed with PHY numbering here.
>>>>=20
>>> The driver simply didn't work if there were multiple ethernet ports.
>>> It always programmed the address of the first available PHY for =
both.
>>=20
>> I thought we tested with two ports on MV-78100, but maybe something =
didn't make it to the SVN tree or got mismerged. So what is the part of =
the patch that fixes this problem, is it this hunk?
>>=20
> Perhaps it did work on the MV-78100 because the bootloader initialised
> the MGE_REG_PHYDEV. Before r201198 the driver simply didn't set that
> register so the driver only worked if the bootloader did that for us.
That's possible, yes.
>> @@ -716,8 +718,7 @@
>> sc->mii =3D device_get_softc(sc->miibus);
>>=20
>> /* Tell the MAC where to find the PHY so autoneg works */
>> - miisc =3D LIST_FIRST(&sc->mii->mii_phys);
>> - MGE_WRITE(sc, MGE_REG_PHYDEV, miisc->mii_phy);
>> + MGE_WRITE(sc, MGE_REG_PHYDEV, sc->phyaddr);
>>=20
>> /* Attach interrupt handlers */
>> for (i =3D 0; i < 2; ++i) {
>>=20
>=20
> That's the one.
Ok, this looks ok to me.
Rafal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AD04D0B-C12C-4909-8BAB-533D7B60157A>