Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 May 2021 15:25:45 GMT
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: c3f3f537715c - stable/13 - pf: Move prototypes for userspace functions to userspace header
Message-ID:  <202105071525.147FPjor026302@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=c3f3f537715c918bdf50f7ec8548ba7ad2778036

commit c3f3f537715c918bdf50f7ec8548ba7ad2778036
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2021-04-07 17:49:51 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-05-07 08:15:42 +0000

    pf: Move prototypes for userspace functions to userspace header
    
    These functions no longer exist in the kernel, so there's no reason to
    keep the prototypes in a kernel header. Move them to pfctl where they're
    actually implemented.
    
    Reviewed by:    glebius
    MFC after:      4 weeks
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    Differential Revision:  https://reviews.freebsd.org/D29643
    
    (cherry picked from commit a9b338b260be39cc74dddb599d6c95b8794ca98b)
---
 sbin/pfctl/pf_ruleset.c | 2 ++
 sbin/pfctl/pfctl.h      | 8 ++++++++
 sys/netpfil/pf/pf.h     | 9 +--------
 3 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/sbin/pfctl/pf_ruleset.c b/sbin/pfctl/pf_ruleset.c
index 7c337d7a2da7..baac1deb4fa7 100644
--- a/sbin/pfctl/pf_ruleset.c
+++ b/sbin/pfctl/pf_ruleset.c
@@ -64,6 +64,8 @@ __FBSDID("$FreeBSD$");
 #define rs_malloc(x)		 calloc(1, x)
 #define rs_free(x)		 free(x)
 
+#include "pfctl.h"
+
 #ifdef PFDEBUG
 #include <sys/stdarg.h>
 #define DPFPRINTF(format, x...)	fprintf(stderr, format , ##x)
diff --git a/sbin/pfctl/pfctl.h b/sbin/pfctl/pfctl.h
index f43b71e19fec..5aa94b2bb0c8 100644
--- a/sbin/pfctl/pfctl.h
+++ b/sbin/pfctl/pfctl.h
@@ -128,4 +128,12 @@ u_int32_t
 	 pfctl_get_ticket(struct pfr_buffer *, int, const char *);
 int	 pfctl_trans(int, struct pfr_buffer *, u_long, int);
 
+int	 pf_get_ruleset_number(u_int8_t);
+void	 pf_init_ruleset(struct pf_ruleset *);
+int	 pf_anchor_setup(struct pf_rule *,
+	    const struct pf_ruleset *, const char *);
+void	 pf_remove_if_empty_ruleset(struct pf_ruleset *);
+struct pf_ruleset	*pf_find_ruleset(const char *);
+struct pf_ruleset	*pf_find_or_create_ruleset(const char *);
+
 #endif /* _PFCTL_H_ */
diff --git a/sys/netpfil/pf/pf.h b/sys/netpfil/pf/pf.h
index bc6cd92ae7b8..3e358de8aba5 100644
--- a/sys/netpfil/pf/pf.h
+++ b/sys/netpfil/pf/pf.h
@@ -637,13 +637,6 @@ struct pf_anchor {
 RB_PROTOTYPE(pf_anchor_global, pf_anchor, entry_global, pf_anchor_compare);
 RB_PROTOTYPE(pf_anchor_node, pf_anchor, entry_node, pf_anchor_compare);
 
-/* these ruleset functions can be linked into userland programs (pfctl) */
-int			 pf_get_ruleset_number(u_int8_t);
-void			 pf_init_ruleset(struct pf_ruleset *);
-int			 pf_anchor_setup(struct pf_rule *,
-			    const struct pf_ruleset *, const char *);
-void			 pf_remove_if_empty_ruleset(struct pf_ruleset *);
-struct pf_ruleset	*pf_find_ruleset(const char *);
-struct pf_ruleset	*pf_find_or_create_ruleset(const char *);
+int	 pf_get_ruleset_number(u_int8_t);
 
 #endif	/* _NET_PF_H_ */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105071525.147FPjor026302>