Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Jul 2016 11:49:45 -0700
From:      Mark Millard <markmi@dsl-only.net>
To:        freebsd-arm <freebsd-arm@freebsd.org>, FreeBSD PowerPC ML <freebsd-ppc@freebsd.org>
Subject:   Re: svn commit: r418841 - in head/benchmarks/iozone: . files
Message-ID:  <362F3D5B-93B2-4E01-9B42-0F3CCDB560F0@dsl-only.net>
In-Reply-To: <C1EB4E1E-E072-4BF7-86BA-76AF061AA511@dsl-only.net>
References:  <8238CC04-1CFA-47DE-8605-9E07CA5B3EE6@dsl-only.net> <C1EB4E1E-E072-4BF7-86BA-76AF061AA511@dsl-only.net>

next in thread | previous in thread | raw e-mail | index | archive | help
[This is a resend: I forgot to list freebsd-arm and freebsd-ppc. See =
https://lists.freebsd.org/pipermail/freebsd-ports/2016-July/104089.html =
for the original.]

https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D418841 is =
broken on armv6, powerpc, and all other ILP32 FreeBSD architectures:

+-typedef long long off64_t;
++typedef long off64_t;

long is not 64-bits but only 32-bits for ILP32 FreeBSD architectures. =
FreeBSD uses 64 bits for off_t even for ILP32 architectures. For FreeBSD =
off_t and iozone's off64_t need to be compatible.

Use of %ld instead of %lld formats have the same issue with ILP32 =
FreeBSD architectures.

+-			sscanf(optarg,"%lld",&kilobytes64);
++			sscanf(optarg,"%ld",&kilobytes64);



See the activity at:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211152


=3D=3D=3D
Mark Millard
markmi at dsl-only.net






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?362F3D5B-93B2-4E01-9B42-0F3CCDB560F0>