Date: Tue, 10 Jan 2012 09:21:06 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r229908 - head/usr.bin/brandelf Message-ID: <20120110082106.GD1801@garage.freebsd.pl> In-Reply-To: <201201100258.q0A2wT7E079753@svn.freebsd.org> References: <201201100258.q0A2wT7E079753@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Jan 10, 2012 at 02:58:29AM +0000, Eitan Adler wrote: > Author: eadler (ports committer) > Date: Tue Jan 10 02:58:29 2012 > New Revision: 229908 > URL: http://svn.freebsd.org/changeset/base/229908 > > Log: > Fix warning when compiling with gcc46: > error: variable 'verbose' set but not use Maybe we should remove -v from the manual page as well or document as no-op? I'd still leave it in the code though, so there is no POLA violation. > Approved by: dim > MFC after: 3 days > > Modified: > head/usr.bin/brandelf/brandelf.c > > Modified: head/usr.bin/brandelf/brandelf.c > ============================================================================== > --- head/usr.bin/brandelf/brandelf.c Tue Jan 10 02:58:20 2012 (r229907) > +++ head/usr.bin/brandelf/brandelf.c Tue Jan 10 02:58:29 2012 (r229908) > @@ -64,7 +64,7 @@ main(int argc, char **argv) > const char *strtype = "FreeBSD"; > int type = ELFOSABI_FREEBSD; > int retval = 0; > - int ch, change = 0, verbose = 0, force = 0, listed = 0; > + int ch, change = 0, force = 0, listed = 0; > > while ((ch = getopt(argc, argv, "f:lt:v")) != -1) > switch (ch) { > @@ -84,7 +84,7 @@ main(int argc, char **argv) > listed = 1; > break; > case 'v': > - verbose = 1; > + /* does nothing */ > break; > case 't': > if (force) -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8L9PIACgkQForvXbEpPzQgrACg1chuGWsO0m6S443+3KqUrcDH GLsAoIxyTpkzISzRCATEaXrjfB7Fo6Zd =XXqs -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120110082106.GD1801>