Date: Wed, 20 Sep 2006 05:04:49 +1000 From: Peter Jeremy <peterjeremy@optushome.com.au> To: Jung-uk Kim <jkim@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <20060919190449.GC720@turion.vk2pj.dyndns.org> In-Reply-To: <200609191431.01649.jkim@FreeBSD.org> References: <200609182218.k8IMIMUT059300@repoman.freebsd.org> <200609181901.47414.jkim@FreeBSD.org> <200609191352.37338.jhb@freebsd.org> <200609191431.01649.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ALfTUftag+2gvp1h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, 2006-Sep-19 14:30:59 -0400, Jung-uk Kim wrote: >On Tuesday 19 September 2006 01:52 pm, John Baldwin wrote: >> Which I'm about to kill hopefully. Please let's fix this the right >> way and not hack it any further. > >Sure, no problem. But I don't think we can DTRT on -STABLE without=20 >breaking API. Can we? I've had a quick look into this problem because I extensively use VLANs on a bge and discovered that I no longer have VLAN tag details (which makes packet tracing a nuisance). As far as I can see, there is nothing preventing bpf_tap() and bpf_mtap2() being doctored to undo the VLAN detagging so that bpf_filter() is passed a mbuf chain that looks like an 802.1Q ethernet frame: Dummy up an mbuf (as bpf_mtap2() does) that contains the MAC addresses from the incoming data followed by the 802.1Q packet type and tag information, with m_next pointing to the byte after the MAC addresses in the original data. --=20 Peter Jeremy --ALfTUftag+2gvp1h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFED9R/opHv/APuIcRAvXeAJ9G24xHV0g6/U1Gnu1dbL3UnaNymgCfT2od 2koKYRn3v1+wPVmAQw8m5rg= =6BOp -----END PGP SIGNATURE----- --ALfTUftag+2gvp1h--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060919190449.GC720>