Date: Mon, 22 Jan 2024 00:53:59 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: "Mikhail T." <mi+t@virtual-estates.net> Cc: Kurt Jaeger <pi@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple Message-ID: <ed9de9e3e2e030630dc95cfbdb1f0abd@mail.infomaniak.com> In-Reply-To: <7ae9295a-0b05-4589-85d9-440ba373707f@virtual-estates.net> References: <202401202030.40KKUApC045320@gitrepo.freebsd.org> <f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com> <f74f9837-121e-47ac-819b-27a40d3b4891@virtual-estates.net> <ewlhhqgckfoo4nj2jmryynhh2admdz6wy3lwkyav7nvhok565l@liht5kzkacig> <7e07375b-32bc-4778-8977-d87d6e135679@virtual-estates.net> <ptq5dukjavkfpoe2gic6mssywdxh7f77xsounaxmy5llxinz2j@w6243b7unduq> <8ab62f5f-bb62-4633-9d1c-d7a8a8e1fc8a@virtual-estates.net> <Zaz0W9odSaxyDrCj@fc.opsec.eu> <13433172-a8cb-494c-a435-fd4d8418a2e6@virtual-estates.net> <21dcca053d36f9bec4005ffb18897f51@mail.infomaniak.com> <df410abd-dd00-4e7e-83eb-f8a95ec15b9f@virtual-estates.net> <d745fc126e79b4455dfc3e87964baa54@mail.infomaniak.com> <7ae9295a-0b05-4589-85d9-440ba373707f@virtual-estates.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1705881239_962c28a3d481e905c4ec2202256d46bc_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-01-21T20:16:19.000+01:00, Mikhail T. <mi+t@virtual-estates.net> w= rote: >=C2=A021.01.24=C2=A013:47,=C2=A0Daniel=C2=A0Engberg: >=C2= =A0 >>=C2=A0=C2=A0While=C2=A0we=C2=A0all=C2=A0do=C2=A0mistakes=C2=A0I'm= =C2=A0asking=C2=A0because=C2=A0it's=C2=A0broken=C2=A0and=C2=A0it's >>= =C2=A0=C2=A0likely=C2=A0not=C2=A0going=C2=A0to=C2=A0be=C2=A0fixed=C2=A0any= =C2=A0time=C2=A0soon. >=C2=A0 >=C2=A0I=C2=A0wonder,=C2=A0how=C2=A0you= =C2=A0estimate=C2=A0this=C2=A0likelihood... >=C2=A0 >>=C2=A0=C2=A0In= =C2=A0reality=C2=A0it=C2=A0adds=C2=A0noise=C2=A0(which=C2=A0we=C2=A0already= =C2=A0have=C2=A0enough=C2=A0of)=C2=A0on >>=C2=A0=C2=A0lists,=C2=A0Poudrie= re=C2=A0builds=C2=A0(because=C2=A0by=C2=A0default=C2=A0we=C2=A0build=C2= =A0all=C2=A0ports) >>=C2=A0=C2=A0takes=C2=A0more=C2=A0time=C2=A0producing= =C2=A0nothing,=C2=A0more=C2=A0time=C2=A0for=C2=A0people=C2=A0to=C2=A0review= >>=C2=A0=C2=A0error=C2=A0logs=C2=A0and=C2=A0so=C2=A0on. >=C2=A0 >= =C2=A0All=C2=A0of=C2=A0this=C2=A0could=C2=A0be=C2=A0silenced=C2=A0with= =C2=A0BROKEN,=C2=A0no? >=C2=A0 >>=C2=A0=C2=A0It=C2=A0boils=C2=A0down= =C2=A0to=C2=A0my=C2=A0time=C2=A0>=C2=A0your=C2=A0time=C2=A0which=C2=A0usual= ly=C2=A0don't=C2=A0translate >>=C2=A0=C2=A0well=C2=A0in=C2=A0team=C2= =A0efforts. >=C2=A0 >=C2=A0No,=C2=A0I=C2=A0don't=C2=A0see=C2=A0it=C2= =A0boiling=C2=A0down=C2=A0to=C2=A0that.=C2=A0To=C2=A0me=C2=A0it=C2=A0seems= =C2=A0like=C2=A0a >=C2=A0simple=C2=A0overreaction.=C2=A0So,=C2=A0a=C2= =A0newly-added=C2=A0port=C2=A0is=C2=A0broken=C2=A0--=C2=A0what's=C2=A0the= >=C2=A0big=C2=A0deal?=C2=A0You'd=C2=A0be=C2=A0right=C2=A0expecting=C2= =A0the=C2=A0committer=C2=A0to=C2=A0=C2=A0examine=C2=A0the >=C2=A0error-lo= g=C2=A0himself...=C2=A0It=C2=A0is=C2=A0just=C2=A0computers=C2=A0working= =C2=A0--=C2=A0so=C2=A0the=C2=A0humans, >=C2=A0present=C2=A0company=C2= =A0included,=C2=A0can=C2=A0do=C2=A0fun=C2=A0things. >=C2=A0 >>=C2=A0= =C2=A0Instead=C2=A0of=C2=A0doing=C2=A0the=C2=A0same=C2=A0thing=C2=A0again= =C2=A0use=C2=A0Poudriere=C2=A0as=C2=A0you're=C2=A0by >>=C2=A0=C2=A0know= =C2=A0well=C2=A0aware=C2=A0that=C2=A0it=C2=A0"should"=C2=A0be=C2=A0used= =C2=A0and=C2=A0you=C2=A0have=C2=A0been >>=C2=A0=C2=A0"warned". >=C2= =A0 >=C2=A0On=C2=A0the=C2=A0contrary=C2=A0--=C2=A0as=C2=A0long=C2=A0as= =C2=A0the=C2=A0"should"=C2=A0remains=C2=A0quoted,=C2=A0I=C2=A0intend >= =C2=A0to=C2=A0do=C2=A0the=C2=A0same=C2=A0thing:_commit,=C2=A0what=C2=A0I= =C2=A0sincerely=C2=A0believe=C2=A0is=C2=A0working >=C2=A0code_.=C2=A0Mat= =C2=A0is=C2=A0already=C2=A0convinced,=C2=A0I=C2=A0MUST=C2=A0follow,=C2= =A0what=C2=A0you=C2=A0acknowledge >=C2=A0is=C2=A0just=C2=A0a=C2=A0recomme= ndation=C2=A0--=C2=A0on=C2=A0the=C2=A0strength=C2=A0of=C2=A0his=C2=A0creati= ng=C2=A0a=C2=A0rule >=C2=A0out=C2=A0of=C2=A0void.=C2=A0Rights=C2=A0not= =C2=A0exercised=C2=A0are=C2=A0rights=C2=A0lost,=C2=A0and=C2=A0all=C2=A0that= =C2=A0:-) >=C2=A0 >>=C2=A0=C2=A0I=C2=A0would=C2=A0also=C2=A0say=C2= =A0that=C2=A0you'd=C2=A0be=C2=A0better=C2=A0off=C2=A0in=C2=A0general=C2= =A0asking=C2=A0for >>=C2=A0=C2=A0suggestions=C2=A0by=C2=A0creating=C2= =A0a=C2=A0PR=C2=A0and=C2=A0or=C2=A0use=C2=A0Phab(ricator)=C2=A0due=C2=A0to= >>=C2=A0=C2=A0quality=C2=A0reasons=C2=A0(to=C2=A0mention=C2=A0it=C2= =A0again,=C2=A0team=C2=A0effort). >=C2=A0 >=C2=A0Believe=C2=A0it=C2= =A0or=C2=A0not,=C2=A0I=C2=A0did=C2=A0ask=C2=A0for=C2=A0suggestions=C2=A0bef= ore=C2=A0committing=C2=A0-- >=C2=A0sending=C2=A0the=C2=A0shar=C2=A0of= =C2=A0the=C2=A0would=C2=A0be=C2=A0port=C2=A0to=C2=A0the=C2=A0committers= =C2=A0of=C2=A0<go.mk> >=C2=A0[http://go.mk>];=C2=A0(because=C2=A0go@FreeB= SD.mk=C2=A0is=C2=A0blocked=C2=A0to >=C2=A0non-subscribers).=C2=A0Having= =C2=A0received=C2=A0no=C2=A0immediate=C2=A0replies,=C2=A0I=C2=A0figured, = >=C2=A0I'll=C2=A0see,=C2=A0what=C2=A0Poudriere=C2=A0would=C2=A0say=C2=A0--= =C2=A0still=C2=A0don't=C2=A0understand=C2=A0the >=C2=A0scale=C2=A0of= =C2=A0the=C2=A0blowback... >=C2=A0 >>=C2=A0=C2=A0-mi Hi, Seem= s like you didn't test 26fa495285d9d7bcd85794665c45d31e1ed1ccb2 ? http= s://pdr2.bofh.network/data/140-diizzy/2024-01-21_17h43m38s/logs/errors/purp= le-gowhatsapp-1.13.0.log Best regards, Daniel --_=_swift_1705881239_962c28a3d481e905c4ec2202256d46bc_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <div>On 2024-01-21T20:16:19.000+01:00, Mikhail T. <mi+t@virtual-estates.= net> wrote:<br></div><div class=3D"ik_mail_quote answerContentMessage"><= blockquote class=3D"ws-ng-quote"><div class=3D"ws-ng-mail-style--12530eJzzz= EvKr9B1K0pNdQp20QILyop1k3Oz83NLCkGAIbYCfk"><div class=3D"">21.01.24 13:47, = Daniel Engberg:<br></div><blockquote type=3D"cite"><div>While we all do mis= takes I'm asking because it's broken and it's likely not going to be fixed any time soon.<br></div></blockqu= ote><div>I wonder, how you estimate this likelihood...<br></div><div> <br><= /div><blockquote type=3D"cite"><div>In reality it adds noise (which we alre= ady have enough of) on lists, Poudriere builds (because by default we build all ports) takes more time producing nothing, more time for people to review error logs and so on.<br></div></blockquote><div>All of this= could be silenced with BROKEN, no?<br></div><blockquote type=3D"cite"><div= >It boils down to my time > your time which usually don't translate well in team efforts.<br></div></blockquote><p>No, I don'= t see it boiling down to that. To me it seems like a simple overreaction. So, a newly-added port is broken -- what's the big deal? You'd be right expecting the committer to examine the error-log himself... It is just computers working -- so the humans, present company included, can do fun things.<br></p><blockquo= te type=3D"cite"><div>Instead of doing the same thing again use Poudriere a= s you're by know well aware that it "should" be used and you have been "warned".<br></div></blockquote><div>On the contrary -- as long as = the "should" remains quoted, I intend to do the same thing:<i>commit, what I sincerely believe is working code</i>. Mat is already convinced, I <b>must</b> follow, what you acknowledge is just a recommendation -- on the strength of his creating a rule out of void. Rights not exercised are rights lost, and all that :-)<br></div><div> <br></div><blockquote type=3D"cit= e"><div>I would also say that you'd be better off in general asking for suggestions by creating a PR and or use Phab(ricator) due to quality reasons (to mention it again, team effort).<br></div></bloc= kquote><p>Believe it or not, I did ask for suggestions before committing -- sending the shar of the would be port to the committers of <<a data-ik=3D"ik-secure" rel=3D"noopener noreferrer" href=3D"http= ://go.mk>" class=3D"defaultMailLink defaultMailLink" target=3D"_blank">go.m= k></a>; (because <a href=3D"mailto:go@FreeBSD.mk" class=3D"defaultMailLi= nk">go@FreeBSD.mk</a> is blocked to non-subscribers). Having received no immediate replies, I figured, I'll see, what Poudriere would say -- still don't understand the scale of the blowback...<br></p><div class=3D"ik-toggle-quote-button"= ><br></div><blockquote><p>-mi<br></p></blockquote></div></blockquote></div>= <div>Hi,<br></div><div><br></div><div>Seems like you didn't test 26fa495285= d9d7bcd85794665c45d31e1ed1ccb2 ?<br></div><div><br></div><div><a href=3D"ht= tps://pdr2.bofh.network/data/140-diizzy/2024-01-21_17h43m38s/logs/errors/pu= rple-gowhatsapp-1.13.0.log">https://pdr2.bofh.network/data/140-diizzy/2024-= 01-21_17h43m38s/logs/errors/purple-gowhatsapp-1.13.0.log</a><br></div><div>= <br></div><div>Best regards,<br></div><div>Daniel<br></div><div><br></div> --_=_swift_1705881239_962c28a3d481e905c4ec2202256d46bc_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ed9de9e3e2e030630dc95cfbdb1f0abd>