Date: Wed, 23 Sep 2015 11:20:03 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r286995 - head/share/mk Message-ID: <5602ED53.3070204@FreeBSD.org> In-Reply-To: <C3E4C746-5028-4D41-A2D4-3E0037A9E2D4@gmail.com> References: <201508211515.t7LFFM0U028322@repo.freebsd.org> <56023395.2080904@FreeBSD.org> <CANCZdfrKeV3yXOs-rQ92SquroL1tpFsr=obPa4a=19F%2Bs%2BZuTA@mail.gmail.com> <5602DB13.2000202@FreeBSD.org> <C3E4C746-5028-4D41-A2D4-3E0037A9E2D4@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 9/23/2015 11:18 AM, Garrett Cooper wrote: > >> On Sep 23, 2015, at 10:02, Bryan Drewery <bdrewery@FreeBSD.org> wrote: >> >>> On 9/23/2015 9:44 AM, Warner Losh wrote: >>> >>> >>> On Tue, Sep 22, 2015 at 10:07 PM, Bryan Drewery <bdrewery@freebsd.org >>> <mailto:bdrewery@freebsd.org>> wrote: >>> >>>> On 8/21/15 8:15 AM, Warner Losh wrote: >>>> Author: imp >>>> Date: Fri Aug 21 15:15:22 2015 >>>> New Revision: 286995 >>>> URL: https://svnweb.freebsd.org/changeset/base/286995 >>>> >>>> Log: >>>> Document bsd.progs.mk <http://bsd.progs.mk>, including its >>> status as being strongly >>>> discouraged and that it will be going away as soon as is >>> practicable. >>>> >>>> Modified: >>>> head/share/mk/bsd.README >>> >>> I find this functionality irreplaceable for simplicity. The alternative >>> is more Makefiles for simple extra progs. Granted it has meta mode >>> dirdeps issues but I think that is acceptable as there are other ways to >>> address that. >>> >>> Where is this deprecation coming from? Is it just due to bapt's >>> in-progress (but not working) patch at https://reviews.freebsd.org/D3444 >>> to remove bsd.progs.mk <http://bsd.progs.mk>; in place of PROGS in >>> bsd.prog.mk <http://bsd.prog.mk>? >>> >>> I would like to document PROGS properly. I had no idea how it worked >>> until reading over it tonight. If the plan wasn't to remove PROGS itself >>> I will do so. >>> >>> >>> It doesn't work and has lots of issues. Those issues haven't been fixed. >>> It didn't look like they would be fixed any time soon. It seemed there >>> was a consensus to deprecate it because of those issues. >>> bapt was part of that group, and his problems with packaging that >>> bsd.progs.mk <http://bsd.progs.mk>; creates played into this decision. >>> >>> If the issues are fixed, then we can change our recommendations based >>> on the changed circumstance. >>> >>> Warner >> >> Yes I think I've addressed the issues. I'm still testing and will have >> it committed soon. It is still fragile, but most of share/mk is. > > I know you've been playing with meta mode a lot. Have you tried building with non-meta mode, with MK_TESTS=yes, then run he following steps as root after a successful installworld? > I'm only doing this in non-meta mode right now. > NOTE: wipe out /usr/tests before running installworld to ensure the files that are present there aren't from previous runs > > cd /usr/tests > kyua test > I am comparing full objtree and destdir from before/after the change, including a 'make clean' comparison. There's no room for missing anything. > Please add me to the CR. > > Thanks, > -NGie > -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWAu1UAAoJEDXXcbtuRpfPgp4IAKWn05v4r3TA1RlQ4Msn91US xpnE6TSACVRin5yV3qbmAlnu9+5kth6d+7UQMn5t4CmSG/utXdbVXmDImFVQltGW jVQOxsYu6Y0PC6FvSo6KW2Wu4wv2zFBHFY/94L2FB46v/69WRWqY883jbxuAQ2D2 aK0yj/NZyeahQtPRsb8oBNltQN8MaDiP7wQ6iUq6H8aRYK2JKePsin+b5nCGHunD i/cTu0VxoHOvQ0tDI4A4opNDxzNiefLWgiNDwOINcDC1qRsyZobcqYFCJTeky3eW u2j9v7AWnrC2thV9MLaHEZVu9PZkhi+i/X65kFkDNFNnQsiMPiMpg9I60XM3iqw= =YD/j -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5602ED53.3070204>