Date: Thu, 27 Oct 2011 14:01:55 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: Olivier Cochard-Labbe <olivier@cochard.me>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/shellinabox Makefile ports/www/shellinabox/files shellinaboxd.in Message-ID: <20111027060155.GB38115@bonjour.sunpoet.net> In-Reply-To: <4EA86333.8090804@FreeBSD.org> References: <201110261620.p9QGK0vV010389@repoman.freebsd.org> <4EA86333.8090804@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--cvVnyQ+4j833TQvp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Oct 26, 2011 at 12:44:51PM -0700, Doug Barton wrote:
> On 10/26/2011 09:20, Sunpoet Po-Chuan Hsieh wrote:
> > sunpoet 2011-10-26 16:20:00 UTC
> >=20
> > FreeBSD ports repository
> >=20
> > Modified files:
> > www/shellinabox Makefile=20
> > www/shellinabox/files shellinaboxd.in=20
> > Log:
> > - Unset shellinaboxd_user and shellinaboxd_group at the end of rc scr=
ipt to
> > avoid unnecessary su(1) initiated by rc.subr
>=20
> I solved this in the named rc.d script by using _uid, which is not
> special to rc.subr; instead of _user, which is. Also, the following
> should probably be changed:
>=20
> if [ "${shellinaboxd_certfile}" =3D "" ]; then
>=20
> to
>=20
> if [ -n "${shellinaboxd_certfile}" ]; then
>=20
> Otherwise this script looks real good, thanks. :)
Hi Doug,
Using _uid/_gid is also a feasible solution to avoid unnecessary su.
However, it would require users to change their rc.conf.
That's why I choose to keep the old variable names. :)
For shellinaboxd_certfile part, it's definitely better to use -z.
Please commit your patch if maintainer approves. Thanks.
Regards,
sunpoet
>=20
> > - Pet portlint
> > - Bump PORTREVISION for package change
> > =20
> > Reported by: ed (in the followup of ports/151314)
> > Approved by: Olivier Cochard-Labbe <olivier@cochard.me> (maintaine=
r)
> > =20
> > Revision Changes Path
> > 1.6 +4 -4 ports/www/shellinabox/Makefile
> > 1.6 +4 -1 ports/www/shellinabox/files/shellinaboxd.in
> >=20
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/shellinabox/Makefile.di=
ff?&r1=3D1.5&r2=3D1.6&f=3Dh
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/shellinabox/files/shell=
inaboxd.in.diff?&r1=3D1.5&r2=3D1.6&f=3Dh
> >=20
>=20
> --=20
>=20
> Nothin' ever doesn't change, but nothin' changes much.
> -- OK Go
>=20
> Breadth of IT experience, and depth of knowledge in the DNS.
> Yours for the right price. :) http://SupersetSolutions.com/
>=20
--=20
Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
--cvVnyQ+4j833TQvp
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
iQIcBAEBAgAGBQJOqPPSAAoJENxEJH7MV+Nr53MP/2Z+87LqFrmwKyY+X/sZ2D7/
YSsLCU1UodHG5y9bB/lTBntVX72CGpZFGqxqX3CpBHRdyJJHiH8wmqobllbd2w10
LpfHvXgvevSiWhor0P4H5SPRILe7zALX2Uh9vT2NdWQuAkp4z/FM0SIIvVv6bImD
y5DX7KtQoibU8E4RxwBLOh8lEWRyNBTWAGpQHlHaUEIMcmyt8XBlYjO54qGiXYGc
U+lqgIueyy9IVfF6TYyPCv8dc0qW7BtSgp4jimOAt2wARF/e2lx2PVqKkGGGM/Lf
v3GoAyvBPD+N6D8gxVoaq4yKwGPdqjTP0Sv+Rtfp/EYaY8Nn7YcfAzZzzrYpN16l
gt0BlGM5MEthpIPSIkjWtDbQXwMkSEvCXPNMf7sXqMHxR9QQGEOIW+vLbdUQIpo4
Ndh9KWCtpMvfD7Uj4d2A92rx4VbqtRuAeH3KT3kQrsMXhZo6q4HJuc4S6sFf8k6D
KTqnPk7lh3Dgr8spNk7qPsP9jqXn2t0cLjkq8dKMo6cqqOVCOgnMFa0dPhlYXZvK
in4iLVL9F0DzZib19YNpb/tOQtZ4IyVgoSCR/B9PIIIgA5Vhd5btmq0oTnK2aaDY
9pqGDiQ1jMtmMSLHZfy6FyY6ydX7p/Un9NXtlLimv3FZ/A7K9B2A5o8PY7r7LRPz
bW6fNeRukBjqr4YsRbzx
=j/6a
-----END PGP SIGNATURE-----
--cvVnyQ+4j833TQvp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111027060155.GB38115>