Date: Wed, 27 Nov 2002 09:47:33 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: dfr@nlsystems.com Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys rman.h src/sys/kern subr_rman.c Message-ID: <20021127.094733.127703189.imp@bsdimp.com> In-Reply-To: <1038397024.8963.1.camel@builder02.qubesoft.com> References: <200211270355.gAR3tMQh036625@repoman.freebsd.org> <1038397024.8963.1.camel@builder02.qubesoft.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <1038397024.8963.1.camel@builder02.qubesoft.com>
Doug Rabson <dfr@nlsystems.com> writes:
: On Wed, 2002-11-27 at 03:55, Warner Losh wrote:
: > imp 2002/11/26 19:55:22 PST
: >
: > Modified files:
: > sys/sys rman.h
: > sys/kern subr_rman.c
: > Log:
: > Make the rman_{get,set}_* macros into real functions. The macros
: > create an ABI that encodes offsets and sizes of structures into client
: > drivers. The functions isolate the ABI from changes to the resource
: > structure. Since these are used very rarely (once at startup), the
: > speed penalty will be down in the noise.
: >
: > Also, add r_rid to the structure so that clients can save the 'rid' of
: > the resource in the struct resource, plus accessor functions. Future
: > additions to newbus will make use of this to present a simplified
: > interface for resource specification.
:
: Can you move the structures out of the public header file now? I
: originally wanted to hide the structures inside the implementation but
: Garret wanted to allow direct access to the structures, I seem to
: remember. The macros were a compromise.
I'll try and see who/what it breaks.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021127.094733.127703189.imp>