Date: Thu, 18 Apr 2024 13:54:41 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: ede456359e55 - main - CONTRIBUTING: mention sys/crypto as another "contrib" directory Message-ID: <CANCZdfqcHEqH8JgRwXpH1x3r81Q6ANa35vj365phAkjQnxAe5w@mail.gmail.com> In-Reply-To: <f2df2c62-a73f-49d8-b617-17f1a9226d4e@FreeBSD.org> References: <202404181857.43IIviHV084762@gitrepo.freebsd.org> <f2df2c62-a73f-49d8-b617-17f1a9226d4e@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Apr 18, 2024, 1:10 PM John Baldwin <jhb@freebsd.org> wrote: > On 4/18/24 11:57 AM, Ed Maste wrote: > > The branch main has been updated by emaste: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=ede456359e55958ab17ac665e5867674a0c0e81b > > > > commit ede456359e55958ab17ac665e5867674a0c0e81b > > Author: Ed Maste <emaste@FreeBSD.org> > > AuthorDate: 2024-04-18 18:44:30 +0000 > > Commit: Ed Maste <emaste@FreeBSD.org> > > CommitDate: 2024-04-18 18:57:19 +0000 > > > > CONTRIBUTING: mention sys/crypto as another "contrib" directory > > > > Reviewed by: imp > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D44857 > > Hmm, sys/crypto is a bit of a mixed bag there. openssl is a mix of > upstream > and local bits. libsodium is an upstream. chacha20 and blake2 I think are > upstreams. rijndael did come from an upstream but I don't think it's > alive. > > I'd actually prefer if we moved a lot of sys/crypto over to sys/dev, e.g. > actual device drivers (as opposed to software crypto implementations) like > aesni, armv8, via, should definitely move to sys/dev. For sys/openssl it > might be nicer then to have the home-grown bits of ossl(4) that aren't from > upstream in a sys/dev/ossl leaving the stock openssl bits in > sys/crypto/openssl. > I like this idea... git makes it easier... this area has historical been a hodgepodge.. Warner > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 18, 2024, 1:10 PM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 4/18/24 11:57 AM, Ed Maste wrote:<br> > The branch main has been updated by emaste:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=ede456359e55958ab17ac665e5867674a0c0e81b" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=ede456359e55958ab17ac665e5867674a0c0e81b</a><br>; > <br> > commit ede456359e55958ab17ac665e5867674a0c0e81b<br> > Author: Ed Maste <emaste@FreeBSD.org><br> > AuthorDate: 2024-04-18 18:44:30 +0000<br> > Commit: Ed Maste <emaste@FreeBSD.org><br> > CommitDate: 2024-04-18 18:57:19 +0000<br> > <br> > CONTRIBUTING: mention sys/crypto as another "contrib" directory<br> > <br> > Reviewed by: imp<br> > Sponsored by: The FreeBSD Foundation<br> > Differential Revision: <a href="https://reviews.freebsd.org/D44857" rel="noreferrer noreferrer" target="_blank">https://reviews.freebsd.org/D44857</a><br>; <br> Hmm, sys/crypto is a bit of a mixed bag there. openssl is a mix of upstream<br> and local bits. libsodium is an upstream. chacha20 and blake2 I think are<br> upstreams. rijndael did come from an upstream but I don't think it's alive.<br> <br> I'd actually prefer if we moved a lot of sys/crypto over to sys/dev, e.g.<br> actual device drivers (as opposed to software crypto implementations) like<br> aesni, armv8, via, should definitely move to sys/dev. For sys/openssl it<br> might be nicer then to have the home-grown bits of ossl(4) that aren't from<br> upstream in a sys/dev/ossl leaving the stock openssl bits in sys/crypto/openssl.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">I like this idea... git makes it easier... this area has historical been a hodgepodge..</div><div dir="auto"><br></div><div dir="auto">Warner </div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"></blockquote></div></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"></blockquote></div></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqcHEqH8JgRwXpH1x3r81Q6ANa35vj365phAkjQnxAe5w>