Date: Wed, 22 Apr 2009 13:31:47 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: stas@FreeBSD.org Cc: svn-src-head@FreeBSD.org, Alexander@Leidinger.net, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191369 - in head/sys: arm/conf dev/iicbus Message-ID: <20090422.133147.-1890035357.imp@bsdimp.com> In-Reply-To: <20090422231511.ca92fb9f.stas@FreeBSD.org> References: <20090422.002643.639875625.imp@bsdimp.com> <20090422090546.110752s7m6p5ao84@webmail.leidinger.net> <20090422231511.ca92fb9f.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20090422231511.ca92fb9f.stas@FreeBSD.org> Stanislav Sedov <stas@FreeBSD.org> writes: : On Wed, 22 Apr 2009 09:05:46 +0200 : Alexander Leidinger <Alexander@Leidinger.net> mentioned: : : > Quoting "M. Warner Losh" <imp@bsdimp.com> (from Wed, 22 Apr 2009 : > 00:26:43 -0600 (MDT)): : > : > > In message: <200904212248.n3LMmCbu027432@svn.freebsd.org> : > > Stanislav Sedov <stas@FreeBSD.org> writes: : > > : Author: stas : > > : Date: Tue Apr 21 22:48:12 2009 : > > : New Revision: 191369 : > > : URL: http://svn.freebsd.org/changeset/base/191369 : > > : : > > : Log: : > > : - Rename ds1672 and ds133x devices to "ds1672_rtc" and "ds133x_rtc" : > > : respectivly. This will allow one to have a kernel with both devices : > > : present and use it for multiple boards with different types of RTC : > > : sitting on a bus. : > > : : > > : Discussed with: imp : > > : > > Hey thanks Stas! Now things are better than before both functionally : > > and cosmetically! Good idea on the names... : > : > <devils_advocate> : > Are those the first devices with an underscore in the name now? If : > yes, do we want this? : > </devils_advocate> : > : : I had the same concerns too, but was not able to come up with anything : better. BTW, I think those devices were the first that ended with a : digit. No. They weren't. There are sound devices that end in digits: # snd_ad1816: Analog Devices AD1816 ISA PnP/non-PnP. # snd_als4000: Avance Logic ALS4000 PCI. # snd_cs4281: Crystal Semiconductor CS4281 PCI. # snd_ds1: Yamaha DS-1 PCI. # snd_emu10k1: Creative EMU10K1 PCI and EMU10K2 (Audigy) PCI. # snd_envy24: VIA Envy24 and compatible, needs snd_spicds. # snd_fm801: Forte Media FM801 PCI. # snd_maestro3: ESS Technology Maestro-3/Allegro PCI. # snd_sb16: Creative SoundBlaster16, to be used in # snd_sb8: Creative SoundBlaster (pre-16), to be used in # snd_via8233: VIA VT8233x PCI. # snd_via82c686: VIA VT82C686A PCI. but since they all live on an enumerated bus, they all share the name "pcm". There are also these: device tnt4882 Nat Ins PCI GPIB card (which does have the digit in the name: static driver_t pci_gpib_driver = { "tnt4882", tnt4882_methods, sizeof(struct tnt_softc) }; ) and the following which are just config options: #device ath_ar5210 # AR5210 chips #device ath_ar5211 # AR5211 chips #device ath_ar5212 # AR5212 chips #device ath_rf2413 #device ath_rf2417 #device ath_rf2425 #device ath_rf5111 #device ath_rf5112 #device ath_rf5413 #device ath_ar5416 # AR5416 chips Interestingly, drm avoids this by: device drm # DRM core module required by DRM drivers device i915drm # Intel i830 through i915 device mach64drm # ATI Rage Pro, Rage Mobility P/M, Rage XL device mgadrm # AGP Matrox G200, G400, G450, G550 device r128drm # ATI Rage 128 I've also been at companies (well one) that have device names that end in digits. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090422.133147.-1890035357.imp>