Date: Sun, 19 Dec 2010 09:42:01 -0800 From: Garrett Cooper <gcooper@FreeBSD.org> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: getting rid of some -mno-* flags under sys/boot Message-ID: <AANLkTimbAzukEahttm9mtQDFtvwN8aEc=RjMVVMqq2n0@mail.gmail.com> In-Reply-To: <20101219112356.GA18388@freebsd.org> References: <20101219112356.GA18388@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 19, 2010 at 3:23 AM, Alexander Best <arundel@freebsd.org> wrote:
> hi there,
>
> i think some of the -mno-* flags in sys/boot/* can be scrubbed, since they're
> already being included from ../Makefile.inc.
Looks good.
> also TARGET cleandir leaves some files behind in i386/gptboot which should be
> fixed by this patch.
AHA. This might fix the issue I've seen rebuilding stuff with
gptzfsboot for a good while now where I have to (on mostly rare
occasions with -j24, etc typically after updating my source tree)
rebuild it manually. gptzfsboot and zfsboot also need the fix, BTW.
The only thing is that these files live under the common directory, so
shouldn't common clean them up (I see that common doesn't have a
Makefile though, only a Makefile.inc -- ouch)?
FWIW though, wouldn't it be better to avoid this accidental bug
and unnecessary duplication by doing something like the following?
# ...
OBJS= zfsboot.o sio.o gpt.o drv.o cons.o util.o
CLEANFILES+= gptzfsboot.out ${OBJS}
gptzfsboot.out: ${BTXCRT} ${OBJS}
# ...
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimbAzukEahttm9mtQDFtvwN8aEc=RjMVVMqq2n0>