Date: Fri, 20 Jan 2012 16:38:54 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Monthadar Al Jaberi <monthadar@gmail.com> Cc: freebsd-wireless@freebsd.org, Bernhard Schmidt <bschmidt@freebsd.org> Subject: Re: 11s mesh path setup problem Message-ID: <CAJ-Vmon0B0ctoe8PN9YheddLV6OL90n8PN-O=3VNX%2BMdu%2B%2B1-w@mail.gmail.com> In-Reply-To: <CA%2BsBSoJ8PBPMnfReiCHEcL_J23rhmCYJrxFPkFrgLpJ-3i_s-g@mail.gmail.com> References: <CA%2BsBSoJWXD5S-zvxHR_=iwh26G0bd00trR=E-jCUBD03uMrU%2BQ@mail.gmail.com> <CAJ-VmomX2NK6p%2BckB6Gc40sz0PTx7cf7NznVLH1tTPvnhmHH6A@mail.gmail.com> <201201112003.44891.bschmidt@freebsd.org> <CA%2BsBSo%2BuYa-6w8VFBMTyhWFHCNezMH5HBHJONCRvWRy6QuaCbQ@mail.gmail.com> <CA%2BsBSoJ8PBPMnfReiCHEcL_J23rhmCYJrxFPkFrgLpJ-3i_s-g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Committed in r230408. Thanks!
adrian
On 16 January 2012 11:46, Monthadar Al Jaberi <monthadar@gmail.com> wrote:
> On Mon, Jan 16, 2012 at 9:39 AM, Monthadar Al Jaberi
> <monthadar@gmail.com> wrote:
> > On Wed, Jan 11, 2012 at 8:03 PM, Bernhard Schmidt <bschmidt@freebsd.org>
> wrote:
> >> On Wednesday 11 January 2012 18:23:29 Adrian Chadd wrote:
> >>> Hi!
> >>>
> >>> I've just done a bit of a code review. Here are my comments:
> >
> > sorry for late answer here is a a better formated patch.
> >
> >>>
> >>> * ether_sprintf() can't be implemented the way you've implemented it -
> >>> it just won't work at all in a multithreaded, concurrent environment.
> >>> We'll have to find an alternative way.
> >>>
> >>> Maybe something like:
> >>>
> >>> char *
> >>> ether_sprintf2(const u_char *ap, char *buf, int len)
> >>> {
> >>> .. do things to buf, rather than the static buf.
> >>> }
> >>>
> >>> Then maybe this'd work:
> >>>
> >>> char a[32], b[32];
> >>> IEEE80211_NOTE(..., ether_sprintf2(addr1, a, 32),
> ether_sprintf2(addr2, a, 32));
> >>>
> >>> does that make sense?
> >>
> >> Isn't there an example in net80211 with %D?
> >> printf("%6D %6D", addr1, ":", addr2, ":");
>
> Ok here is a patch just for fixing ieee80211_hwmp IEEE80211_NOTE
> function calls before my patch.
> does it look okej?
>
> >>
> >> The saner alternative is to call printf() multiple times, see
> ieee80211_dump_pkt() as an example.
> >
> > But that means we have to modify for example ieee80211_note_mac function?
> >
> >>
> >> --
> >> Bernhard
> >
> >
> >
> > --
> > Monthadar Al Jaberi
>
>
>
> --
> Monthadar Al Jaberi
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmon0B0ctoe8PN9YheddLV6OL90n8PN-O=3VNX%2BMdu%2B%2B1-w>