Date: Tue, 08 Oct 2013 10:00:51 +0200 From: =?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?= <dumbbell@FreeBSD.org> To: sbruno@freebsd.org, "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: Re: [patch] Re: drm2/radeon dfixed_trunc() warnings Message-ID: <5253BBB3.3040302@FreeBSD.org> In-Reply-To: <1381172676.3091.0.camel@localhost> References: <1381095549.1586.7.camel@localhost> <1381172676.3091.0.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 07.10.2013 21:04, Sean Bruno wrote: > Proposed patch to eliminate this check. If I understand the macro > correctly, there's no way for these checks to ever do anything as bit > shifting an unsigned will simply clear out the value. So, the check for > <0 is completely bogus? Hello! I think you're right. I saw Clang reporting those warnings. Coverity has many more. I didn't want to fix them for now, to ease future merges from Linux. The plan is to submit patches to upstream at some point. Thanks for the patch! I should prepare a branch to store that kind of fixes. -- Jean-Sébastien Pédron [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJTu70ACgkQa+xGJsFYOlNkHACgz4Pjn22okp+9A+Foa9lRonzI UfAAn1sc/ENt6smUhtzdGhbv5r8wYJIG =lvmN -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5253BBB3.3040302>