Date: Sun, 29 Jul 2018 13:36:58 -0700 From: Mark Millard <marklmi@yahoo.com> To: Brad Davis <brd@FreeBSD.org> Cc: svn-src-head@freebsd.org Subject: Re: svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk Message-ID: <F3F1B134-709F-454A-921D-D760DDE3AE18@yahoo.com> In-Reply-To: <1532836798.1025520.1456191920.7D934477@webmail.messagingengine.com> References: <EFD410C3-0F6D-4426-9A12-4C0FD59D4EAA@yahoo.com> <1532836798.1025520.1456191920.7D934477@webmail.messagingengine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2018-Jul-28, at 8:59 PM, Brad Davis <brd at FreeBSD.org> wrote:
> On Sat, Jul 28, 2018, at 9:53 PM, Mark Millard wrote:
>> Brad Davis brd at FreeBSD.org wrote on
>> Thu Jul 26 17:11:15 UTC 2018 :
>>=20
>>> On Thu, Jul 26, 2018, at 11:09 AM, Shawn Webb wrote:
>>> . . .
>>>>> -FILES=3D ${.CURDIR}/pf????.in
>>>>> -FILES+=3D ${.CURDIR}/pf????.include
>>>>> -FILES+=3D ${.CURDIR}/pf????.ok
>>>>> +FILES!=3D echo ${.CURDIR}/pf????.in =
${.CURDIR}/pf????.include ${.CURDIR}/pf????.ok
>>>>=20
>>>> Should this use ${ECHO} instead of echo?
>>>=20
>>>=20
>>> No, that wouldn't work at all with the !=3D.
>>=20
>> /usr/ports/Mk/bsd.port.mk has things like:
>>=20
>> OPSYS!=3D ${UNAME} -s
>> and:
>> _OSRELEASE!=3D ${UNAME} -r
>>=20
>> Is your ${ECHO} note specific to the combination of ${ECHO} and !=3D
>> for some reason --or does it apply to the likes of ${UNAME} mixed
>> with !=3D too?
>=20
> That is different.. due to share/mk/sys.mk has:
>=20
> .if empty(.MAKEFLAGS:M-s)
> ECHO ?=3D echo
> ECHODIR ?=3D echo
> .else
> ECHO ?=3D true
> .if ${.MAKEFLAGS:M-s} =3D=3D "-s"
> ECHODIR ?=3D echo
> .else
> ECHODIR ?=3D true
> .endif
> .endif
>=20
> Which means if someone is using make -s, these tests would not =
install.. which is probably not what is desired and there are better =
ways to do that.
Thanks.
Looking around I see that /usr/ports/Mk/bsd.commands.mk has:
# ECHO is defined in /usr/share/mk/sys.mk, which can either be "echo",
# or "true" if the make flag -s is given. Use ECHO_CMD where you mean
# the echo command.
ECHO_CMD?=3D echo # Shell builtin
# Used to print all the '=3D=3D=3D>' style prompts - override this to =
turn them off.
ECHO_MSG?=3D ${ECHO_CMD}
So may be ${ECHO_CMD} would be an alternate to echo.
=3D=3D=3D
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F3F1B134-709F-454A-921D-D760DDE3AE18>